Added note about rclcpp/qos_event.hpp removal in Jazzy #4137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
reviewed
Jan 26, 2024
There was a problem hiding this comment.
The note looks great, but if you make the change to #4138 (review) , this will have a conflict and need a rebase.
…event_deprecation_remove
|
@clalancette rebase done. |
clalancette
approved these changes
Jan 26, 2024
clalancette
added
the
backport-all
delete-merged-branch
bot
deleted the
ahcorde/jazzy/qos_event_deprecation_remove
branch
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit c3e44bf)
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit c3e44bf)
This was referenced Jan 26, 2024
clalancette
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit c3e44bf) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit c3e44bf) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this PR ros2/rclcpp#2413
Added note about
rclcpp/qos_event.hppremoval in Jazzy