Note about removed deprecated headers #4138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
reviewed
Jan 26, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
@ahcorde The note looks great.
I know you didn't do this, but would you mind moving this entire "New features in this ROS 2 release" section above, right under "Installation"? That will restore the flow that we usually have for these pages. Thanks in advance.
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Contributor
Author
|
@clalancette sure, done here 468e4bf |
clalancette
requested changes
Jan 26, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
One minor change to the wording, then I think this is good to go. Thanks for doing the rearrangement!
Comment on lines
52
to
53
| ``tf2_kdl/tf2_kdl.h``, ``tf2_sensor_msgs/tf2_sensor_msgs.h`` headers been completely removed. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| ``tf2_kdl/tf2_kdl.h``, ``tf2_sensor_msgs/tf2_sensor_msgs.h`` headers been completely removed. | |
| ``tf2_kdl/tf2_kdl.h``, ``tf2_sensor_msgs/tf2_sensor_msgs.h`` headers have been completely removed. |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
approved these changes
Jan 26, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good, thank you for iterating!
clalancette
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Note about removed deprecated headers Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 7f5cc33)
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Note about removed deprecated headers Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 7f5cc33)
This was referenced Jan 26, 2024
clalancette
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Note about removed deprecated headers Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 7f5cc33) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Note about removed deprecated headers Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 7f5cc33) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this PR ros2/geometry2#645
Note about removed deprecated headers