Use target_link_libraries instead of ament_target_dependencies #2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
VX792,
bmagyar,
christophfroehlich,
harderthan,
homalozoa and
livanov93
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2266 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 143 143
Lines 16436 16436
Branches 1422 1422
=======================================
+ Hits 14615 14616 +1
+ Misses 1268 1267 -1
Partials 553 553
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2025
(cherry picked from commit 210bb1c)
christophfroehlich
pushed a commit
that referenced
this pull request
May 23, 2025
#2271) (cherry picked from commit 210bb1c) Co-authored-by: Sai Kishor Kothakota <[email protected]>
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2210
Fixes: #2257
Fixes: ros-controls/control_toolbox#369
Fixes: ros-controls/realtime_tools#329
Fixes: ros-controls/kinematics_interface#141