Use target_link_libraries instead of ament_target_dependencies #1697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Maverobot,
christophfroehlich,
destogl,
erickisos,
mcbed,
mhubii and
olivier-stasse
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1697 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 123 123
Lines 11896 11896
Branches 1015 1015
=======================================
Hits 10194 10194
Misses 1379 1379
Partials 323 323
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christophfroehlich
approved these changes
May 24, 2025
christophfroehlich
merged commit f3236c5
into
ros-controls:master
21 of 27 checks passed
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2025
(cherry picked from commit f3236c5)
christophfroehlich
pushed a commit
that referenced
this pull request
May 24, 2025
…ort #1697) (#1699) Co-authored-by: Sai Kishor Kothakota <[email protected]>
This was referenced May 26, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might need ros-controls/ros2_control#2266