Skip to content

Conversation

@ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Feb 1, 2022

This closes #135

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

Will be squashed merged due to messy history.
Needs to create a followup for handling TLS connection

Additional Context

@ChunyiLyu ChunyiLyu marked this pull request as draft February 1, 2022 19:15
@ChunyiLyu ChunyiLyu marked this pull request as ready for review February 3, 2022 14:41
@ChunyiLyu ChunyiLyu changed the title WIP: add rabbitmqClusterReference.connectionSecret Add rabbitmqClusterReference.connectionSecret Feb 3, 2022
Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test live now.

Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing an issue where if I create a topology object, then the RabbitMQ cluster disappears for whatever reason, the object is stuck in failed delete forever as the operator hits tcp timeouts trying to connect.

In the case where we're using a LocalClusterReference, and we fail to find the RMQ, we assume it's been deleted and we delete the underlying topology object; I'd like to see a similar thing here potentially. There is a trade off, in that a cluster may only be temporarily unavailable while a user does a delete operation, and we'd leave some state around, but I think that's a better solution than having users do a k delete --force.

Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One neat thing this provides is that it solves this issue: #287

@Zerpet
Copy link
Member

Zerpet commented Feb 4, 2022

I'm seeing an issue where if I create a topology object, then the RabbitMQ cluster disappears for whatever reason, the object is stuck in failed delete forever as the operator hits tcp timeouts trying to connect.

In the case where we're using a LocalClusterReference, and we fail to find the RMQ, we assume it's been deleted and we delete the underlying topology object; I'd like to see a similar thing here potentially. There is a trade off, in that a cluster may only be temporarily unavailable while a user does a delete operation, and we'd leave some state around, but I think that's a better solution than having users do a k delete --force.

This behaviour is similar to what's described in #277. Big plus if this PR also fixes that problem.

Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following on from our chat on Zoom, LGTM! Just one concern about an accidentally included file potentially?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to use existing RabbitMQ clusters that are not created/managed by https://github.com/rabbitmq/cluster-operator

4 participants