-
Notifications
You must be signed in to change notification settings - Fork 78
Add rabbitmqClusterReference.connectionSecret #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nce.connectionSecret
4fb8be8 to
1d0f1bc
Compare
coro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will test live now.
coro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing an issue where if I create a topology object, then the RabbitMQ cluster disappears for whatever reason, the object is stuck in failed delete forever as the operator hits tcp timeouts trying to connect.
In the case where we're using a LocalClusterReference, and we fail to find the RMQ, we assume it's been deleted and we delete the underlying topology object; I'd like to see a similar thing here potentially. There is a trade off, in that a cluster may only be temporarily unavailable while a user does a delete operation, and we'd leave some state around, but I think that's a better solution than having users do a k delete --force.
coro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One neat thing this provides is that it solves this issue: #287
This behaviour is similar to what's described in #277. Big plus if this PR also fixes that problem. |
coro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following on from our chat on Zoom, LGTM! Just one concern about an accidentally included file potentially?
This closes #135
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Will be squashed merged due to messy history.
Needs to create a followup for handling TLS connection
Additional Context