Support for internal domain name as env var #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coro
reviewed
Feb 21, 2022
Comment on lines
+11
to
+13
| ### Tools | ||
| # Allows flexbility to use other build kits, like nerdctl | ||
| BUILD_KIT ?= /usr/local/bin/docker |
MirahImage
requested changes
Feb 23, 2022
[#233] Signed-off-by: Aitor Perez Cedres <[email protected]>
It makes it easier to refactor/rename an env var. The env var to hint the internal cluster domain is also renamed, based on feedback from #233. Tests pass without those lines. The two tests that use this variable in 'rabbitmq_client_factory_test.go` call the same arguments. Signed-off-by: Aitor Perez Cedres <[email protected]>
Kubernetes internal domain name can be customised during the cluster creation. Some certificates are issued with a 'star domain', so that any subdomain can be validated. In these cases, the Topology Operator needs a 'hint' about this internal domain, so that it can connect to the correct URI to communicate with RabbitMQ. Related to #233. Signed-off-by: Aitor Perez Cedres <[email protected]>
The variable broke the workflow because the GitHub Actions containers do not have Docker executable in the default location set in the Makefile. Signed-off-by: Aitor Perez Cedres <[email protected]>
Zerpet
force-pushed
the
issue-233-rebase-2
branch
from
729c3a1 to
4c25eef
Compare
Zerpet
commented
Feb 28, 2022
Comment on lines
+111
to
+117
| It("sets the domain name in the URI to connect to RabbitMQ", func() { | ||
| for _, controller := range topologyControllers { | ||
| controller.SetInternalDomainName(".some-domain.com") | ||
| } | ||
|
|
||
| for i, _ := range topologyControllers { | ||
| Expect(client.Create(ctx, topologyObjects[i])).To(Succeed()) |
Member
Author
There was a problem hiding this comment.
This test was a bit flaky. For some reason, sometimes the test would fail by not adding the internal domain name. By splitting in two different loops the "setup" and the "tests", the flake seems to go away.
MirahImage
approved these changes
Mar 1, 2022
coro
approved these changes
Mar 1, 2022
This was referenced Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related #233
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Additional Context
It's notable the testing strategy used to test this new feature. In order to test that a controller is using the property, I had to expose such property in the controller's struct, and add a function that allows to interact with such property. Secondly, the interface was necessary to avoid duplicating the same code multiple times, in every controller test. The addition of this interface seems to have no impact, and it allows us to test common controller functionality in one place.
There's been no work done to allow arbitrary URI strings, as that use case is better covered by #294 and #296.
Pending to PR the docs to document this new feature.