Skip to content

Conversation

@ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Mar 21, 2022

Changes

  • 🧹 bump RabbitMQ clusters and messaging topology operator to their latest versions
  • with the latest version of the messaging topology operator, eventing-rabbitmq can take advantage of the RabbitMQ connection secret feature that was recently added (doc)

How to bump RabbitMQ operator versions

  1. manually update operator version in go.mod to the desired version (this is because hack/update-deps.sh won't automatically update operator versions)
  2. run hack/update-deps.sh which will update go.sum, vendored RabbitMQ operators, and other dependencies that the script automatically updates
  3. run hack/generate-codegen.sh which will update codegen generated clientSet, informers and listeners for the RabbitMQ operators (See Rework the way eventing-rabbitmq does Rabbit codegen #378 for details)

/kind enhancement

@knative-prow-robot knative-prow-robot added kind/enhancement size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChunyiLyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #657 (4e08a86) into main (8404950) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   75.04%   75.04%           
=======================================
  Files          47       47           
  Lines        2881     2881           
=======================================
  Hits         2162     2162           
  Misses        581      581           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8404950...4e08a86. Read the comment docs.

@gab-satchi
Copy link
Contributor

Failed conformance for the known issue with DLQs:

2022-03-21T13:55:45.5013291Z     event_patterns.go:121: Expected Events brokerdlq; 
2022-03-21T13:55:45.5013622Z          Got: knconf.EventPattern{Success:[]bool{}, Interval:[]uint{}}
2022-03-21T13:55:45.5013960Z         Want: knconf.EventPattern{Success:[]bool{true}, Interval:[]uint{0x0}}

re-runing for a green signal
/hold
/retest

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/lgtm

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
@knative-prow-robot knative-prow-robot merged commit 037cd83 into knative-extensions:main Mar 21, 2022
@ChunyiLyu ChunyiLyu deleted the bump-rabbit-operators branch March 21, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants