Skip to content

Conversation

willeastcott
Copy link
Contributor

No description provided.

@willeastcott willeastcott requested a review from Copilot August 7, 2025 16:45
@willeastcott willeastcott self-assigned this Aug 7, 2025
@willeastcott willeastcott added the enhancement New feature or request label Aug 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates example HTML files to use new attribute syntax after an engine update, primarily consolidating zoom configuration from separate min/max properties to a unified range property.

  • Replaced zoomMin and zoomMax attributes with consolidated zoomRange vector property
  • Updated first-person controller script to use local assets and add camera entity reference
  • Added missing zoom configuration to examples that previously lacked it

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
video-texture.html Consolidated zoom attributes to zoomRange
text3d.html Consolidated zoom attributes to zoomRange
splat.html Consolidated zoom attributes to zoomRange
shoe-configurator.html Consolidated zoom attributes to zoomRange
physics.html Added missing zoomRange attribute
glb.html Added missing zoomRange attribute
fps-controller.html Updated script asset path and added camera entity reference
car-configurator.html Consolidated zoom attributes with different range values
basic-shapes.html Added sceneSize and zoomRange attributes
annotations.html Added missing zoomRange attribute
animation.html Consolidated zoom attributes and adjusted camera position

@willeastcott willeastcott merged commit 2fb54e8 into main Aug 7, 2025
2 checks passed
@willeastcott willeastcott deleted the attr-updates branch August 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant