Skip to content

Commit 2fb54e8

Browse files
authored
Update example attributes after engine update (#180)
* Update example attributes after engine update * Revert path to fps script
1 parent 730703e commit 2fb54e8

File tree

11 files changed

+19
-18
lines changed

11 files changed

+19
-18
lines changed

examples/animation.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,14 @@
2929
<pc-sky asset="lake-bed" type="dome" lighting></pc-sky>
3030
<!-- Camera (with XR support) -->
3131
<pc-entity name="camera root">
32-
<pc-entity name="camera" position="3 1.5 5">
32+
<pc-entity name="camera" position="4.5 1.5 6.5">
3333
<pc-camera></pc-camera>
3434
<pc-scripts>
3535
<pc-script name="cameraControls" attributes='{
3636
"focusPoint": "vec3:0,1.75,2",
3737
"pitchRange": "vec2:-90,0",
3838
"sceneSize": 15,
39-
"zoomMin": 0.5,
40-
"zoomMax": 15
39+
"zoomRange": "vec2:2,15"
4140
}'></pc-script>
4241
</pc-scripts>
4342
</pc-entity>

examples/annotations.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
<pc-script name="cameraControls" attributes='{
4040
"focusPoint": "vec3:0,1.75,0",
4141
"pitchRange": "vec2:-90,0",
42-
"sceneSize": 2
42+
"sceneSize": 2,
43+
"zoomRange": "vec2:5,25"
4344
}'></pc-script>
4445
</pc-scripts>
4546
</pc-entity>

examples/basic-shapes.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@
3838
"enableFly": false,
3939
"enablePan": false,
4040
"focusPoint": "vec3:0,0.5,0",
41-
"pitchRange": "vec2:-90,0"
41+
"pitchRange": "vec2:-90,0",
42+
"sceneSize": 5,
43+
"zoomRange": "vec2:0.1,10"
4244
}'></pc-script>
4345
</pc-scripts>
4446
</pc-entity>

examples/car-configurator.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@
4141
"focusPoint": "vec3:0,0.5,0",
4242
"pitchRange": "vec2:-90,0",
4343
"sceneSize": 10,
44-
"zoomMin": 0.25,
45-
"zoomMax": 1
44+
"zoomRange": "vec2:2.5,15"
4645
}'></pc-script>
4746
</pc-scripts>
4847
</pc-entity>

examples/fps-controller.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@
3636
<pc-collision type="capsule" radius="0.5" height="1.8"></pc-collision>
3737
<pc-rigidbody type="dynamic" angular-factor="0 0 0" mass="100" friction="0.5" restitution="0"></pc-rigidbody>
3838
<pc-scripts>
39-
<pc-script name="firstPersonController"></pc-script>
39+
<pc-script name="firstPersonController" attributes='{
40+
"camera": "entity:camera"
41+
}'></pc-script>
4042
</pc-scripts>
4143
</pc-entity>
4244
<!-- Map -->

examples/glb.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
<pc-script name="cameraControls" attributes='{
3636
"enableFly": false,
3737
"enablePan": false,
38-
"sceneSize": 1
38+
"sceneSize": 1,
39+
"zoomRange": "vec2:1,10"
3940
}'></pc-script>
4041
</pc-scripts>
4142
</pc-entity>

examples/physics.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
<pc-camera clear-color="#222222"></pc-camera>
3636
<pc-scripts>
3737
<pc-script name="cameraControls" attributes='{
38-
"sceneSize": 10
38+
"sceneSize": 10,
39+
"zoomRange": "vec2:0.1,100"
3940
}'></pc-script>
4041
</pc-scripts>
4142
</pc-entity>

examples/shoe-configurator.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@
3737
"enablePan": false,
3838
"focusPoint": "vec3:0,0.05,0",
3939
"sceneSize": 0.5,
40-
"zoomMin": 0.25,
41-
"zoomMax": 1
40+
"zoomRange": "vec2:0.25,1"
4241
}'></pc-script>
4342
</pc-scripts>
4443
</pc-entity>

examples/splat.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@
3737
"focusPoint": "vec3:0,2,0",
3838
"pitchRange": "vec2:-90,0",
3939
"sceneSize": 3,
40-
"zoomMin": 0.5,
41-
"zoomMax": 3
40+
"zoomRange": "vec2:0.5,3"
4241
}'></pc-script>
4342
</pc-scripts>
4443
</pc-entity>

examples/text3d.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
<pc-script name="cameraControls" attributes='{
3636
"focusPoint": "vec3:0,0.5,0",
3737
"sceneSize": 10,
38-
"zoomMin": 0.1,
39-
"zoomMax": 10
38+
"zoomRange": "vec2:0.1,10"
4039
}'></pc-script>
4140
</pc-scripts>
4241
</pc-entity>

0 commit comments

Comments
 (0)