Skip to content

Update example attributes after engine update #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Update example attributes after engine update #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae6e47
Update example attributes after engine update
willeastcott Aug 7, 2025
15035a7
Revert path to fps script
willeastcott Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions examples/animation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,14 @@
<pc-sky asset="lake-bed" type="dome" lighting></pc-sky>
<!-- Camera (with XR support) -->
<pc-entity name="camera root">
<pc-entity name="camera" position="3 1.5 5">
<pc-entity name="camera" position="4.5 1.5 6.5">
<pc-camera></pc-camera>
<pc-scripts>
<pc-script name="cameraControls" attributes='{
"focusPoint": "vec3:0,1.75,2",
"pitchRange": "vec2:-90,0",
"sceneSize": 15,
"zoomMin": 0.5,
"zoomMax": 15
"zoomRange": "vec2:2,15"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
3 changes: 2 additions & 1 deletion examples/annotations.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@
<pc-script name="cameraControls" attributes='{
"focusPoint": "vec3:0,1.75,0",
"pitchRange": "vec2:-90,0",
"sceneSize": 2
"sceneSize": 2,
"zoomRange": "vec2:5,25"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
4 changes: 3 additions & 1 deletion examples/basic-shapes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
"enableFly": false,
"enablePan": false,
"focusPoint": "vec3:0,0.5,0",
"pitchRange": "vec2:-90,0"
"pitchRange": "vec2:-90,0",
"sceneSize": 5,
"zoomRange": "vec2:0.1,10"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
3 changes: 1 addition & 2 deletions examples/car-configurator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
"focusPoint": "vec3:0,0.5,0",
"pitchRange": "vec2:-90,0",
"sceneSize": 10,
"zoomMin": 0.25,
"zoomMax": 1
"zoomRange": "vec2:2.5,15"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
4 changes: 3 additions & 1 deletion examples/fps-controller.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@
<pc-collision type="capsule" radius="0.5" height="1.8"></pc-collision>
<pc-rigidbody type="dynamic" angular-factor="0 0 0" mass="100" friction="0.5" restitution="0"></pc-rigidbody>
<pc-scripts>
<pc-script name="firstPersonController"></pc-script>
<pc-script name="firstPersonController" attributes='{
"camera": "entity:camera"
}'></pc-script>
</pc-scripts>
</pc-entity>
<!-- Map -->
Expand Down
3 changes: 2 additions & 1 deletion examples/glb.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
<pc-script name="cameraControls" attributes='{
"enableFly": false,
"enablePan": false,
"sceneSize": 1
"sceneSize": 1,
"zoomRange": "vec2:1,10"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
3 changes: 2 additions & 1 deletion examples/physics.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
<pc-camera clear-color="#222222"></pc-camera>
<pc-scripts>
<pc-script name="cameraControls" attributes='{
"sceneSize": 10
"sceneSize": 10,
"zoomRange": "vec2:0.1,100"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
3 changes: 1 addition & 2 deletions examples/shoe-configurator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@
"enablePan": false,
"focusPoint": "vec3:0,0.05,0",
"sceneSize": 0.5,
"zoomMin": 0.25,
"zoomMax": 1
"zoomRange": "vec2:0.25,1"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
3 changes: 1 addition & 2 deletions examples/splat.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@
"focusPoint": "vec3:0,2,0",
"pitchRange": "vec2:-90,0",
"sceneSize": 3,
"zoomMin": 0.5,
"zoomMax": 3
"zoomRange": "vec2:0.5,3"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
3 changes: 1 addition & 2 deletions examples/text3d.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
<pc-script name="cameraControls" attributes='{
"focusPoint": "vec3:0,0.5,0",
"sceneSize": 10,
"zoomMin": 0.1,
"zoomMax": 10
"zoomRange": "vec2:0.1,10"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down
3 changes: 1 addition & 2 deletions examples/video-texture.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@
"focusPoint": "vec3:0,0.225,0",
"pitchRange": "vec2:-90,0",
"sceneSize": 1,
"zoomMin": 0.5,
"zoomMax": 3
"zoomRange": "vec2:0.5,3"
}'></pc-script>
</pc-scripts>
</pc-entity>
Expand Down