Run tests on Windows in Github Actions #531
Conversation
owais
force-pushed
the
windows-ci
branch
17 times, most recently
from
386e778 to
51e7caf
Compare
owais
force-pushed
the
windows-ci
branch
12 times, most recently
from
9e679af to
f00d06c
Compare
| self.assertIsNone(client.parent) | ||
| self.assertEqual(client.kind, SpanKind.CLIENT) | ||
| self.assert_span_has_attributes( | ||
| self.assertSpanHasAttributes( |
There was a problem hiding this comment.
Can you split the renaming out of this PR? It would make reviews a bit cleaner
There was a problem hiding this comment.
open-telemetry/opentelemetry-python#2084
#641
Easiest thing to do right now for me is to merge the above PRs and then rebase this one to shrink the size of the PR. Please review.
|
|
||
| ; opentelemetry-instrumentation-sqlalchemy | ||
| py3{6,7,8,9}-test-instrumentation-sqlalchemy{11,14} | ||
| py3{6,7}-test-instrumentation-sqlalchemy{11} |
| | if .[0].benchmarks == null then null else .[0] end' | ||
| **/**/tests/*${{ matrix.package }}*-benchmark.json > output.json | ||
| - name: Report on benchmark results | ||
| # TODO: fix and enable on windows |
There was a problem hiding this comment.
Please file an issue to track this
| - name: run tox | ||
| run: tox -f ${{ matrix.python-version }}-${{ matrix.package }} -- --benchmark-json=${{ env.RUN_MATRIX_COMBINATION }}-benchmark.json | ||
| - name: Find and merge benchmarks | ||
| # TODO: fix and enable on windows |
There was a problem hiding this comment.
Please file an issue to track this
owais
force-pushed
the
windows-ci
branch
2 times, most recently
from
8a2955d to
e48eb18
Compare
owais
force-pushed
the
windows-ci
branch
2 times, most recently
from
013adb2 to
ceac768
Compare
|
I'm running into some more issues with pypy on windows. Looking into it. Please DO NOT merge even if all jobs pass. |
owais
force-pushed
the
windows-ci
branch
3 times, most recently
from
b56e6c8 to
c881bf5
Compare
|
Turns out cryptography already published prebuilt binary wheels for windows+pypy+amd64. Using x64 Python fixes the issue and doesn't require us to build it from source. |
@owais Please mark any PR that is not to be merged as draft to avoid accidents ✌️ |
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for splitting out the PR, makes this review much easier 👍
4 participants
Description
Run tests on Windows
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.