More consistent assertion methods #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
aabmass and
ocelotl
and removed request for
a team
11 tasks
12 tasks
codeboten
reviewed
Aug 30, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Nice, thanks for breaking this up! Looks like lint needs fixing, otherwise it looks good
owais
force-pushed
the
upgrade-assertion-methods
branch
5 times, most recently
from
eb87e75 to
74605ff
Compare
owais
commented
Aug 30, 2021
| assert spans | ||
| span = spans[2] | ||
| self.assertEqual( | ||
| span.attributes, |
Contributor
Author
There was a problem hiding this comment.
these are failing now as the underlying library is generating a unique ID per request which is recorded as an attribute so we can no longer use assertEqual.
owais
force-pushed
the
upgrade-assertion-methods
branch
from
74605ff to
637ef45
Compare
codeboten
approved these changes
Aug 30, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
👍 just a comment on the name of the method, which I should mentioned in the PR to rename the method
|
|
||
| # Check version and name in span's instrumentation info | ||
| self.check_span_instrumentation_info( | ||
| self.assertSpanInstrumentationInfo( |
Contributor
There was a problem hiding this comment.
Nit: I would rename this asserSpanHasInstrumentationInfo to make it more consistent
owais
force-pushed
the
upgrade-assertion-methods
branch
from
637ef45 to
1a665d6
Compare
aabmass
approved these changes
Aug 30, 2021
owais
force-pushed
the
upgrade-assertion-methods
branch
from
1a665d6 to
2a92e25
Compare
ocelotl
approved these changes
Aug 30, 2021
codeboten
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update base test class to have more consistent assertion methods with rest of Python ecosystem.
Fix breaking botocore instrumentation tests
Dev/Tooling enchancement
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.