Skip to content

Commit b56e6c8

Browse files
committed
Merge branch 'main' into windows-ci
2 parents 2a56c1d + c279ee5 commit b56e6c8

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

.github/workflows/test.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
py37: 3.7
1717
py38: 3.8
1818
py39: 3.9
19-
pypy3: pypy3
19+
pypy3: pypy-3.7
2020
RUN_MATRIX_COMBINATION: ${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }}
2121
runs-on: ${{ matrix.os }}
2222
strategy:
@@ -55,6 +55,13 @@ jobs:
5555
id: windows-pypy-check
5656
if: ${{ matrix.os == 'windows-2019' && matrix.python-version == 'pypy3' && matrix.package == 'instrumentation' }}
5757
run: echo "::set-output name=found::true"
58+
59+
- name: Download cryptography wheel
60+
if: steps.windows-pypy-check.outputs.found
61+
run: |
62+
pip download --only-binary :all: --dest . --no-cache cryptography
63+
ls
64+
5865
- name: Win+PyPy - Setup Rust Crates
5966
if: steps.windows-pypy-check.outputs.found
6067
run: rustup target add i686-pc-windows-msvc

tests/opentelemetry-docker-tests/tests/celery/test_celery_functional.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414

1515

1616
import celery
17-
import pytest
1817
from celery.exceptions import Retry
18+
from flaky import flaky
19+
from pytest import mark
1920

2021
import opentelemetry.instrumentation.celery
2122
from opentelemetry import trace as trace_api
@@ -33,7 +34,7 @@ class MyException(Exception):
3334
pass
3435

3536

36-
@pytest.mark.skip(reason="inconsistent test results")
37+
@mark.skip(reason="inconsistent test results")
3738
def test_instrumentation_info(celery_app, memory_exporter):
3839
@celery_app.task
3940
def fn_task():
@@ -143,7 +144,7 @@ def fn_task(self):
143144
assert span.attributes.get("celery.state") == "SUCCESS"
144145

145146

146-
@pytest.mark.skip(reason="inconsistent test results")
147+
@mark.skip(reason="inconsistent test results")
147148
def test_fn_task_apply_async(celery_app, memory_exporter):
148149
@celery_app.task
149150
def fn_task_parameters(user, force_logout=False):
@@ -190,7 +191,7 @@ def fn_task_parameters(user, force_logout=False):
190191
)
191192

192193

193-
@pytest.mark.skip(reason="inconsistent test results")
194+
@mark.skip(reason="inconsistent test results")
194195
def test_concurrent_delays(celery_app, memory_exporter):
195196
@celery_app.task
196197
def fn_task():
@@ -206,7 +207,7 @@ def fn_task():
206207
assert len(spans) == 200
207208

208209

209-
@pytest.mark.skip(reason="inconsistent test results")
210+
@mark.skip(reason="inconsistent test results")
210211
def test_fn_task_delay(celery_app, memory_exporter):
211212
@celery_app.task
212213
def fn_task_parameters(user, force_logout=False):
@@ -476,7 +477,7 @@ def add(x, y):
476477
)
477478

478479

479-
@pytest.mark.skip(reason="inconsistent test results")
480+
@mark.skip(reason="inconsistent test results")
480481
def test_apply_async_previous_style_tasks(
481482
celery_app, celery_worker, memory_exporter
482483
):
@@ -558,6 +559,8 @@ class CelerySubClass(CelerySuperClass):
558559
) == async_run_span.attributes.get(SpanAttributes.MESSAGING_MESSAGE_ID)
559560

560561

562+
# FIXME find a permanent solution for the flakiness of this test
563+
@flaky
561564
def test_custom_tracer_provider(celery_app, memory_exporter):
562565
@celery_app.task
563566
def fn_task():

tox.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,7 @@ deps =
409409
protobuf>=3.13.0
410410
requests==2.25.0
411411
pyodbc~=4.0.30
412+
flaky==3.7.0
412413

413414
changedir =
414415
tests/opentelemetry-docker-tests/tests

0 commit comments

Comments
 (0)