Feature implementation from commits de7384e..870e29d #1

codeOwlAI · 2025-06-30T14:09:03Z

This PR contains changes from a range of commits from the original repository.

Commit Range: de7384e..870e29d
Files Changed: 41 (39 programming files)
Programming Ratio: 95.1%

Commits included:

[misc] add additional metrics ([misc] add additional metrics netbirdio/netbird#4028)
[client] close windows when process needs to exit ([client] close window when process needs to exit netbirdio/netbird#4027)
[client] Refactor showLoginURL to improve error handling and connection status checks ([client] Refactor showLoginURL to improve error handling and connection status checks netbirdio/netbird#4026)
[client] Handle lazy routing peers that are part of HA groups ([client] Handle lazy routing peers that are part of HA groups netbirdio/netbird#3943)
[management] add transaction for integrated validator groups update and primary account update ([management] add transaction for integrated validator groups update and prim acc netbirdio/netbird#4014)
[management] export ephemeral peer flag on api ([management] export ephemeral peer flag on api netbirdio/netbird#4004)
[management] Add backward compatibility for older clients without firewall rules port range support ([management] Add backward compatibility for older clients without firewall rules port range support netbirdio/netbird#4003)
[client] Fix port range squashing ([client] Fix port range squashing netbirdio/netbird#4007)
[client] Add more Android advanced settings ([client] Add more Android advanced settings netbirdio/netbird#4001)
Fix route notification
... and 5 more commits

[client] Fix DNS Interceptor Build Error

* Avoid recalculating next peer expiration - Check if an account schedule is already running - Cancel executing schedules only when changes occurs - Add more context info to logs * fix tests

…te (netbirdio#3994) [client] Fix logic in updateStatus to correctly handle connection state (netbirdio#3994)

[client] fix connection state handling (netbirdio#3995)

On Android ignore the dynamic roots in the route notifications

…ewall rules port range support (netbirdio#4003) Adds backward compatibility for clients with versions prior to v0.48.0 that do not support port range firewall rules. - Skips generation of firewall rules with multi-port ranges for older clients - Preserves support for single-port ranges by treating them as individual port rules, ensuring compatibility with older clients

…nd primary account update (netbirdio#4014)

…dio#3943) * Activate new lazy routing peers if the HA group is active * Prevent lazy peers going to idle if HA group members are active (netbirdio#3948)

…on status checks (netbirdio#4026) This PR refactors showLoginURL to improve error handling and connection status checks by delaying the login fetch until user interaction and closing the pop-up if already connected. - Moved s.login(false) call into the click handler to defer network I/O. - Added a conn.Status check after opening the URL to skip reconnection if already connected. - Enhanced error logs for missing verification URLs and service status failures.

This PR fixes a bug by ensuring that the advanced settings and re-authentication windows are closed appropriately when the main GUI process exits. - Updated runSelfCommand calls throughout the UI to pass a context parameter. - Modified runSelfCommand’s signature and its internal command invocation to use exec.CommandContext for proper cancellation handling.

* add additional metrics we are collecting active rosenpass, ssh from the client side we are also collecting active user peers and active users * remove duplicated

codeowlai · 2025-06-30T14:21:58Z

client/internal/lazyconn/manager/manager.go

 }

-func (m *Manager) AddPeer(peerCfg lazyconn.PeerConfig) (bool, error) {
+func (m *Manager) AddPeer(ctx context.Context, peerCfg lazyconn.PeerConfig) (bool, error) {


🐛 Correctness Issue

Breaking API Change: Missing Context Parameter.

Adding a context parameter to AddPeer() method will break all existing callers that don't provide this parameter, causing compilation failures.

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

func (m *Manager) AddPeer(ctx context.Context, peerCfg lazyconn.PeerConfig) (bool, error) {

func (m *Manager) AddPeer(ctx context.Context, peerCfg lazyconn.PeerConfig) (bool, error) {

codeowlai · 2025-06-30T14:22:02Z

client/ui/event_handler.go

 	go func() {
 		defer h.client.mNetworks.Enable()
-		h.runSelfCommand("networks", "true")
+		h.runSelfCommand(h.client.ctx, "networks", "true")


🐛 Correctness Issue

Missing required context parameter.

The runSelfCommand function requires a context parameter that was missing, which would cause compilation failure or runtime errors.

Current Code (Diff):

- h.runSelfCommand("networks", "true") + h.runSelfCommand(h.client.ctx, "networks", "true")

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

h.runSelfCommand(h.client.ctx, "networks", "true")

h.runSelfCommand(h.client.ctx, "networks", "true")

codeowlai · 2025-06-30T14:22:05Z

management/server/peer.go


 	for _, p := range userPeers {
-		aclPeers, _ := account.GetPeerConnectionResources(ctx, p.ID, approvedPeersMap)
+		aclPeers, _ := account.GetPeerConnectionResources(ctx, p, approvedPeersMap)


🐛 Correctness Issue

Type mismatch in function parameter.

Changed from passing p.ID to passing the entire p object to GetPeerConnectionResources, which could cause runtime errors if the function expects an ID rather than an object.

Current Code (Diff):

- aclPeers, _ := account.GetPeerConnectionResources(ctx, p, approvedPeersMap) + aclPeers, _ := account.GetPeerConnectionResources(ctx, p.ID, approvedPeersMap)

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

aclPeers, _ := account.GetPeerConnectionResources(ctx, p, approvedPeersMap)

aclPeers, _ := account.GetPeerConnectionResources(ctx, p.ID, approvedPeersMap)

codeowlai · 2025-06-30T14:22:10Z

management/server/route.go

+	}
+
+	if len(routeToSave.Domains) > 0 {
+		routeToSave.Network = getPlaceholderIP()


🐛 Correctness Issue

Undefined function getPlaceholderIP().

The code calls getPlaceholderIP() which is not defined in this hunk, potentially causing runtime errors if not defined elsewhere in the codebase.

codeowlai · 2025-06-30T14:22:13Z

management/server/route.go

+		return err
+	}
+
+	return checkRoutePrefixOrDomainsExistForPeers(ctx, transaction, accountID, routeToSave, groupsMap)


🐛 Correctness Issue

Undefined function checkRoutePrefixOrDomainsExistForPeers().

The function checkRoutePrefixOrDomainsExistForPeers() is called but not defined in this hunk, which could lead to runtime errors if not defined elsewhere.

codeowlai · 2025-06-30T14:22:17Z

management/server/route.go

+	}
+
+	if len(routeToSave.PeerGroups) > 0 {
+		if err = validateGroups(routeToSave.PeerGroups, groupsMap); err != nil {


🐛 Correctness Issue

Undefined function validateGroups().

The function validateGroups() is called multiple times but not defined in this hunk, potentially causing runtime errors if not defined elsewhere.

hakansa and others added 15 commits June 17, 2025 16:07

[client] Fix DNS Interceptor Build Error (netbirdio#3993)

f61ebdb

[client] Fix DNS Interceptor Build Error

[management] Avoid recalculating next peer expiration (netbirdio#3991)

af2b427

* Avoid recalculating next peer expiration - Check if an account schedule is already running - Cancel executing schedules only when changes occurs - Add more context info to logs * fix tests

[client] Fix logic in updateStatus to correctly handle connection sta…

81d8324

…te (netbirdio#3994) [client] Fix logic in updateStatus to correctly handle connection state (netbirdio#3994)

[client] fix connection state handling (netbirdio#3995)

08c9107

[client] fix connection state handling (netbirdio#3995)

[management] Refactor routes to use store methods (netbirdio#2928)

7c6b85b

Fix route notification

91f7ee6

On Android ignore the dynamic roots in the route notifications

[client] Add more Android advanced settings (netbirdio#4001)

0e5dc9d

[client] Fix port range squashing (netbirdio#4007)

23b5d45

[management] export ephemeral peer flag on api (netbirdio#4004)

b45284f

[management] add transaction for integrated validator groups update a…

83457f8

…nd primary account update (netbirdio#4014)

[client] Handle lazy routing peers that are part of HA groups (netbir…

2a51609

…dio#3943) * Activate new lazy routing peers if the HA group is active * Prevent lazy peers going to idle if HA group members are active (netbirdio#3948)

[misc] add additional metrics (netbirdio#4028)

870e29d

* add additional metrics we are collecting active rosenpass, ssh from the client side we are also collecting active user peers and active users * remove duplicated

codeowlai bot reviewed Jun 30, 2025

View reviewed changes

codeOwlAI closed this Jun 30, 2025

codeOwlAI reopened this Jun 30, 2025

codeOwlAI closed this Jun 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature implementation from commits de7384e..870e29d #1

Feature implementation from commits de7384e..870e29d #1

Uh oh!

codeOwlAI commented Jun 30, 2025

Uh oh!

codeowlai bot Jun 30, 2025

Uh oh!

codeowlai bot Jun 30, 2025

Uh oh!

codeowlai bot Jun 30, 2025

Uh oh!

codeowlai bot Jun 30, 2025

Uh oh!

codeowlai bot Jun 30, 2025

Uh oh!

codeowlai bot Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	func (m *Manager) AddPeer(ctx context.Context, peerCfg lazyconn.PeerConfig) (bool, error) {
	func (m *Manager) AddPeer(ctx context.Context, peerCfg lazyconn.PeerConfig) (bool, error) {

	h.runSelfCommand(h.client.ctx, "networks", "true")
	h.runSelfCommand(h.client.ctx, "networks", "true")

	aclPeers, _ := account.GetPeerConnectionResources(ctx, p, approvedPeersMap)
	aclPeers, _ := account.GetPeerConnectionResources(ctx, p.ID, approvedPeersMap)

Feature implementation from commits de7384e..870e29d #1

Feature implementation from commits de7384e..870e29d #1

Uh oh!

Conversation

codeOwlAI commented Jun 30, 2025

Uh oh!

codeowlai bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants