content: Mention containerd 1.7 supports user namespaces #40264

rata · 2023-03-23T10:56:10Z

containerd 1.7 was just released with user namespaces support. Let's mention this.

Also, let's emphasize in the task page that only supported runtimes work with user namespaces.

@sftim doing only one PR against main is enough for this to show for 1.25 and 1.26? Let me know if I should open another PR for the other branch or what

cc @SergeyKanzhelev

netlify · 2023-03-23T11:07:41Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`05400ef`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/641c304d102eab0008687028
😎 Deploy Preview	https://deploy-preview-40264--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

SergeyKanzhelev

/lgtm

rata · 2023-03-24T11:02:57Z

Rebased and pushed to see if the CI works now. @SergeyKanzhelev can you re-LGTM? :)

netlify · 2023-03-24T11:09:10Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`d2cd6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6421a6a059b61d0007020a07
😎 Deploy Preview	https://deploy-preview-40264--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

SergeyKanzhelev

/lgtm

sftim

I very strongly recommend revising this before we merge it.

content/en/docs/concepts/workloads/pods/user-namespaces.md

content/en/docs/tasks/configure-pod-container/user-namespaces.md

sftim · 2023-03-25T16:54:06Z

In fact, with #40264 (review) in mind:

/lgtm cancel

rata · 2023-03-27T10:55:43Z

content/en/docs/concepts/workloads/pods/user-namespaces.md

-* containerd: support is planned for the 1.7 release. See containerd
-  issue [#7063][containerd-userns-issue] for more details.
+* containerd: version 1.7 supports user namespaces for containers, compatible
+  with Kubernetes {{< skew currentVersion >}}. If you are running a different


This will break if we apply this to 1.25. This will point to kubernetes 1.24, IIUC, which simply doesn't support user namespaces

Yep, I don't recommend backporting this line to the v1.25 docs

IMHO it will be simpler if we just use the versions, as they are not relative to any k8s version. In fact, here just expands to k8s 1.26, but this is true with k8s 1.25 too.

I'd prefer calling out the specific version in this context.
We say "the WWII ended in 1945" instead of "in {{ current year }}, the WWII has ended." with a constant refreshing of the {{ current year }}.

Historical events aren't quite the right analogy. It's about a commutative relationship between (releases of) two things. The containerd docs might want to express the reverse relationship for example.

The text I've proposed for v1.27 also uses a skew shortcode (for a different reason).

I guess if we're sure that v1.7 of containerd is compatible specifically with v1.26 of Kubernetes and no other minor version of this project, we should say exactly that (and keep the “If you are running a different version of Kubernetes, check the documentation for that Kubernetes release.”)

However, this is an unusual case because of when we're making the change, ie after the code freeze for v1.27

@sftim what change is after code freeze? This doc PR?

First, this doc isn't for 1.27. This is for 1.25 and 1.26.

Secondly, that statement is true for 1.25 and 1.26, I don't understand why you insist in mentioning only one release.

And yes, we re-worked the implementation in 1.27 and what we need other requirements from the runtime. That is why it is not recommended to use 1.7 for userns with k8s >= 1.27.

But to return to more practical matter, how do you want me to phrase it here? So we can merge this PR

I commented: https://github.com/kubernetes/website/pull/40264/files#r1149286339

@sftim that link is not working (github is having hiccups, maybe is due to that). Can you please explain here again? Or a suggestion is even better ;)

Ah, try #40264 (review)

@sftim thanks not sure what you mean, though. Yes, I'll open another PR for 1.25, but what change in the content here do you expect to see? I don't follow, sorry

rata · 2023-03-27T10:58:09Z

@sftim PTAL, all comments are addressed now.

How will this work once this PR and PRs for 1.27 are merged? (#39860 and #40335) I think merging the main branch with the dev-1.27 might have conflicts, what happens in that case?

Also, I applied the suggestion to use the k8s skew version template thingy, but I think that will break when this is merged with the 1.25 branch (see the comment I added on that line for more details). What should we do? Can't we just use the hardcoded k8s versions (1.25 and 1.26) as what we really want is those versions and not something relative to the current k8s version?

sftim · 2023-03-27T11:25:54Z

We have a team that resolve merge conflicts. Consider putting in an HTML comment that explains your intent about the merge conflict that will arise.

I don't understand the shortcoming that we have with using {{< skew currentVersion >}} for the change to main. What worry do you have?

rata · 2023-03-27T11:28:03Z

@sftim I'll add an html comment, thanks

My concern is that using version skrew does not expend to 1.26 AND 1.25 (which is what is accurate in this context) and can't be backported. If you want to keep it, I'm fine with it...

rata · 2023-03-27T11:34:24Z

@sftim added the comment, thanks. PTAL

content/en/docs/concepts/workloads/pods/user-namespaces.md

content/en/docs/tasks/configure-pod-container/user-namespaces.md

containerd 1.7 was just released with user namespaces support. Let's mention which kubernetes versions should work with container 1.7. While we are there, let's clarify the CRI-O version and not duplicate the requirements in the concept and task pages and just add a link Signed-off-by: Rodrigo Campos <[email protected]>

rata · 2023-03-27T14:21:56Z

@sftim Fixed, PTAL

Review was stale

SergeyKanzhelev · 2023-03-27T16:58:13Z

/lgtm

thank you @sftim for all the feedback.

k8s-ci-robot · 2023-03-27T16:58:19Z

LGTM label has been added.

Git tree hash: 491469ab6dbe3c37912cf396113498ac0a05467d

reylejano · 2023-04-04T05:58:39Z

Previews:

Thank you for addressing feedback
/approve

k8s-ci-robot · 2023-04-04T05:59:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2023

k8s-ci-robot requested a review from divya-mohan0209 March 23, 2023 10:56

k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 23, 2023

k8s-ci-robot requested a review from mengjiao-liu March 23, 2023 10:56

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 23, 2023

SergeyKanzhelev approved these changes Mar 24, 2023

View reviewed changes

k8s-ci-robot assigned SergeyKanzhelev Mar 24, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023

rata force-pushed the rata/userns-1.25 branch from 761442b to 1332cf9 Compare March 24, 2023 11:02

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023

k8s-ci-robot requested a review from SergeyKanzhelev March 24, 2023 11:02

SergeyKanzhelev approved these changes Mar 24, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023

sftim previously requested changes Mar 24, 2023

View reviewed changes

k8s-ci-robot assigned sftim Mar 25, 2023

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2023

k8s-ci-robot requested a review from SergeyKanzhelev March 25, 2023 16:54

rata force-pushed the rata/userns-1.25 branch 2 times, most recently from fb71333 to b00862e Compare March 27, 2023 10:38

This was referenced Mar 27, 2023

Document user namespace changes in v1.27 (KEP-127) #39860

Merged

Remove "new" word in userns documentation #40335

Merged

rata commented Mar 27, 2023

View reviewed changes

rata force-pushed the rata/userns-1.25 branch from b00862e to 136ffd5 Compare March 27, 2023 11:33

rata requested review from sftim and removed request for SergeyKanzhelev, divya-mohan0209 and mengjiao-liu March 27, 2023 12:05

sftim reviewed Mar 27, 2023

View reviewed changes

content/en/docs/concepts/workloads/pods/user-namespaces.md Outdated Show resolved Hide resolved

sftim reviewed Mar 27, 2023

View reviewed changes

content/en/docs/tasks/configure-pod-container/user-namespaces.md Outdated Show resolved Hide resolved

rata force-pushed the rata/userns-1.25 branch from 136ffd5 to d2cd6ca Compare March 27, 2023 14:21

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023

k8s-ci-robot merged commit 9360bc5 into kubernetes:main Apr 4, 2023

rata deleted the rata/userns-1.25 branch April 4, 2023 09:46

rata mentioned this pull request Apr 4, 2023

content: Mention containerd 1.7 supports user namespaces #40487

Merged

content: Mention containerd 1.7 supports user namespaces #40264

content: Mention containerd 1.7 supports user namespaces #40264

Uh oh!

Conversation

rata commented Mar 23, 2023

Uh oh!

netlify bot commented Mar 23, 2023

✅ Pull request preview available for checking

Uh oh!

SergeyKanzhelev left a comment

Choose a reason for hiding this comment

Uh oh!

rata commented Mar 24, 2023

Uh oh!

netlify bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

SergeyKanzhelev left a comment

Choose a reason for hiding this comment

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sftim commented Mar 25, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rata commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sftim commented Mar 27, 2023

Uh oh!

rata commented Mar 27, 2023

Uh oh!

rata commented Mar 27, 2023

Uh oh!

Uh oh!

Uh oh!

rata commented Mar 27, 2023

Uh oh!

SergeyKanzhelev commented Mar 27, 2023

Uh oh!

k8s-ci-robot commented Mar 27, 2023

Uh oh!

reylejano commented Apr 4, 2023

Uh oh!

k8s-ci-robot commented Apr 4, 2023

Uh oh!

Reviewers

Assignees

Labels

netlify bot commented Mar 24, 2023 •

edited

Loading

rata commented Mar 27, 2023 •

edited

Loading