content: Mention containerd 1.7 supports user namespaces #40487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
sftim
reviewed
Apr 4, 2023
Contributor
sftim
left a comment
sftim
left a comment
There was a problem hiding this comment.
Thanks.
I recommend two tweaks.
Member
Author
|
@sftim fixed all, PTAL |
Member
Author
|
@sftim friendly ping? |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 283c3cdb10c8ecc710e714e7efe20677c1617767
|
Member
Author
|
@sftim @bradtopol @onlydole ping? |
1 similar comment
Member
Author
|
@sftim @bradtopol @onlydole ping? |
Contributor
|
The target 'dev-1.25' is incorrect. It should have been deleted. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/M
Member
Author
|
@tengqm I switched to that branch now. Is there anything else missing? |
containerd 1.7 was just released with user namespaces support. Let's mention which kubernetes versions should work with container 1.7. While we are there, let's clarify the CRI-O version and not duplicate the requirements in the concept and task pages and just add a link Signed-off-by: Rodrigo Campos <[email protected]>
k8s-ci-robot
removed
the
lgtm
✅ Deploy Preview for k8s-v1-25 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
size/S
Contributor
|
Thanks. |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SergeyKanzhelev, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 742a2b86231630ab3fbfca604f849511924c5c1d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #40264 to 1.25 docs. It applies without conflicts.
containerd 1.7 was just released with user namespaces support. Let's mention this.
Also, let's emphasize in the task page that only supported runtimes work with user namespaces.
cc @SergeyKanzhelev