Skip to content

Conversation

@rata
Copy link
Member

@rata rata commented Mar 27, 2023

This PR fixes the issue noticed by @sftim here: #40264 (comment).

While we are there, we also change pod.spec to pod spec.

Opening in a new PR as @sftim seems to prefer that, let's see if these PRs not create conflicts with each other... 🤞

While we are there, we also change pod.spec to pod spec.

Signed-off-by: Rodrigo Campos <[email protected]>
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2023
@netlify
Copy link

netlify bot commented Mar 27, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e07c3d6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64217556b1009e0008a9344c

@tengqm
Copy link
Contributor

tengqm commented Mar 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57be8814493f08fc8eacb9900a1919fb69aab9a6

@sftim
Copy link
Contributor

sftim commented Mar 27, 2023

/retitle Remove "new" word in userns documentation

(here, “new” is an English word, and not the keyword new)

@k8s-ci-robot k8s-ci-robot changed the title content: Remove "new" keyword in userns documentation Remove "new" word in userns documentation Mar 27, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit af957d0 into kubernetes:dev-1.27 Mar 27, 2023
@rata rata deleted the rata/userns-remove-new-field-reference branch March 27, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants