[KEP-3962]Promote MAP to beta in 1.34

[cici37]

• One-line PR description:

• Issue link: Mutating Admission Policies #3962

• Other comments:

[kannon92]

Just checking.
https://github.com/kubernetes/enhancements/blob/893ac352d7954e1410d66fce872523e05c6eb7fe/keps/sig-api-machinery/3962-mutating-admission-policies/README.md#metrics

Are these metrics the ones you still want to implement?

[cici37]

Yes mostly^^

[jpbetz]

SIG leads chatted about KEPs. The ask for this KEP is that we verify this KEP meets all the new Beta criteria: https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/5241-beta-featuregate-promotion-requirements

[jpbetz]

/assign @deads2k

[deads2k]

SIG leads chatted about KEPs. The ask for this KEP is that we verify this KEP meets all the new Beta criteria: https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/5241-beta-featuregate-promotion-requirements

I think we have a couple gaps on the criteria for this PR right now. Once those are addressed, I think we can be ready.

[cici37]

Thank you for the review. I have rephrased the criteria based on new sig arch guidance. Thanks

[kannon92]

I think you should revisit some of the PRR questions again.

As we promote to beta, we should answer these questions more concretely.

https://github.com/kubernetes/enhancements/blob/3a4c61b071028e13687e9897b76804c3e3472012/keps/sig-api-machinery/3962-mutating-admission-policies/README.md#were-upgrade-and-rollback-tested-was-the-upgrade-downgrade-upgrade-path-tested

There should be a walkthrough of the upgrade testing that will be performanced (and ideally it will be done before promoting to feature gate on).

https://github.com/kubernetes/enhancements/blob/3a4c61b071028e13687e9897b76804c3e3472012/keps/sig-api-machinery/3962-mutating-admission-policies/README.md#are-there-any-missing-metrics-that-would-be-useful-to-have-to-improve-observability-of-this-feature

Do you need more input on metrics or is what you have sufficient?

https://github.com/kubernetes/enhancements/blob/3a4c61b071028e13687e9897b76804c3e3472012/keps/sig-api-machinery/3962-mutating-admission-policies/README.md#how-does-this-feature-react-if-the-api-server-andor-etcd-is-unavailable

This question is unanswered.

[cici37]

@kannon92 Thanks for the review. I have added more details for the PRR section. Please take a look when you have time :)

[kannon92]

TY!

LGTM.

/assign @deads2k

[deads2k]

PRR looks good. sig content looks good. Please update the one criteria bit I highlighted.

/approve

[deads2k]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/prod-readiness/OWNERS [deads2k]
• keps/sig-api-machinery/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment