Skip to content

Commit db268ff

Browse files
committed
Address comment
1 parent 3a4c61b commit db268ff

File tree

1 file changed

+12
-2
lines changed
  • keps/sig-api-machinery/3962-mutating-admission-policies

1 file changed

+12
-2
lines changed

keps/sig-api-machinery/3962-mutating-admission-policies/README.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1298,7 +1298,16 @@ Describe manual testing that was done and the outcomes.
12981298
Longer term, we may want to require automated upgrade/rollback tests, but we
12991299
are missing a bunch of machinery and tooling and can't do that now.
13001300
-->
1301-
Upgrade and rollback will be tested before the feature goes to Beta.
1301+
Upgrade and rollback will be tested manually in a kind:
1302+
1303+
- Enabled feature gate, created a MutatingAdmissionPolicy and MutatingAdmissionPolicyBinding with mutation to add a label to a pod.
1304+
1305+
- Disabled feature gate, restarted apiserver, confirmed that the
1306+
MutatingAdmissionPolicy and MutatingAdmissionPolicyBinding still exist. Added another Pod
1307+
to verify that the mutation would not happen.
1308+
1309+
- Re-enabled the feature gate, restarted apiserver, confirmed that
1310+
the mutation will occur for new incoming pod creation request.
13021311

13031312
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
13041313

@@ -1378,7 +1387,7 @@ Pick one more of these and delete the rest.
13781387
Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
13791388
implementation difficulties, etc.).
13801389
-->
1381-
No. We are open to input.
1390+
No.
13821391

13831392
### Dependencies
13841393

@@ -1513,6 +1522,7 @@ details). For now, we leave it here.
15131522
-->
15141523

15151524
###### How does this feature react if the API server and/or etcd is unavailable?
1525+
No change from existing behavior. The feature will serve same as if it's disabled.
15161526

15171527
###### What are other known failure modes?
15181528

0 commit comments

Comments
 (0)