-
Notifications
You must be signed in to change notification settings - Fork 1.6k
self nominate kannon92 for production readiness approval #5662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
self nominate kannon92 for production readiness approval #5662
Conversation
|
I'm still working on gathering the checklist so putting it in WIP for now. |
|
Great work Kevin. You've shadowed with me for two releases and handled some difficult situations and a large breadth KEPs. +1 /approve holding so other PRR approvers have a chance to review and comment too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from my side as well
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k, kannon92, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
+1 Appreciate the attention to detail. /lgtm |
|
/lgtm +1 for comments above - really solid and thorough work! |
PRR example
#4566
Shadow contribution summary:
28
Planned future involvement:
Shadow reviewer promotion criteria:
Transitions from new to alpha
Transitions from alpha to beta
Transitions from beta to GA
Must have successfully reviewed at least three enhancements that require coordination between multiple components.
Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.
Must have successfully reviewed at least three enhancements that are outside your primary domain.
I would say my domain is sig-apps and sig-node.
Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.
Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.