Skip to content

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Oct 20, 2025

PRR example
#4566

Shadow contribution summary:

  • 1.33 shadow reviews:
    28
  • 1.34 shadow reviews: 30
  • 1.35 shadow reviews: 10

Planned future involvement:

  • 1.36 - I hope to take more reviews as an approver and help shadow.

Shadow reviewer promotion criteria:

Transitions from new to alpha

Transitions from alpha to beta

Transitions from beta to GA

Must have successfully reviewed at least three enhancements that require coordination between multiple components.

Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.

Must have successfully reviewed at least three enhancements that are outside your primary domain.

I would say my domain is sig-apps and sig-node.

Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.

Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2025
@kannon92
Copy link
Contributor Author

I'm still working on gathering the checklist so putting it in WIP for now.

@kannon92
Copy link
Contributor Author

@kannon92 kannon92 changed the title WIP: self nominate kannon92 for production readiness approval self nominate kannon92 for production readiness approval Oct 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
@deads2k
Copy link
Contributor

deads2k commented Nov 6, 2025

Great work Kevin. You've shadowed with me for two releases and handled some difficult situations and a large breadth KEPs.

+1

/approve
/hold

holding so other PRR approvers have a chance to review and comment too.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my side as well

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, kannon92, soltysh
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpbetz
Copy link
Contributor

jpbetz commented Nov 6, 2025

+1

Appreciate the attention to detail.

/lgtm

@wojtek-t
Copy link
Member

wojtek-t commented Nov 6, 2025

/lgtm

+1 for comments above - really solid and thorough work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants