-
-
Notifications
You must be signed in to change notification settings - Fork 225
Fix #2710 - Return macOS instead of 'Darwin' and return proper version #3956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2c82b5a
Initial commit
aritchie 3e40806
Finish
aritchie 5144dba
Update CHANGELOG.md
aritchie 78619f5
Update CHANGELOG.md
aritchie 9c3aa53
Update Sentry.Maui.Device.TestApp.csproj
aritchie 16d4ce8
Update EnricherTests.cs
aritchie f8c2acd
Update CHANGELOG.md
aritchie 63dc0ce
Merge branch 'main' into 2710-macos_version
aritchie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #if NET6_0_OR_GREATER | ||
| using Sentry.Tests; | ||
|
|
||
| namespace Sentry.Maui.Tests; | ||
|
|
||
| public class EnricherTests | ||
| { | ||
| [PlatformFact(Platform.MacOS)] | ||
| public void macOS_Platform_Version() | ||
| { | ||
| var elike = Substitute.For<IEventLike>(); | ||
| elike.Sdk.Returns(new SdkVersion()); | ||
| elike.User = new SentryUser(); | ||
| elike.Contexts = new SentryContexts(); | ||
|
|
||
| var enricher = new Enricher(new SentryOptions()); | ||
| enricher.Apply(elike); | ||
|
|
||
| var os = elike.Contexts.OperatingSystem; | ||
| os.Name.Should().Be("macOS"); | ||
| os.Version.Should().Be(Environment.OSVersion.Version.ToString()); | ||
| } | ||
| } | ||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| namespace Sentry.Tests; | ||
|
|
||
| public enum Platform | ||
| { | ||
| Windows, | ||
| Linux, | ||
| MacOS | ||
| } | ||
|
|
||
| public class PlatformFact : FactAttribute | ||
| { | ||
| public PlatformFact(Platform platform) | ||
| { | ||
| var actual = platform switch | ||
| { | ||
| Platform.Windows => OSPlatform.Windows, | ||
| Platform.Linux => OSPlatform.Linux, | ||
| Platform.MacOS => OSPlatform.OSX, | ||
| _ => throw new NotSupportedException() | ||
| }; | ||
|
|
||
| if (!RuntimeInformation.IsOSPlatform(actual)) | ||
| Skip = "Ignored - Not Platform: " + actual; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.