Skip to content

Conversation

@aritchie
Copy link
Contributor

Resolves #2710

Enricher will now check if running in a mac environment (runtime as we don't target mac targetframework) and switch "Darin" to "macOS" as well as set the operating system version properly

NOTES:

  • The native library was using compiler checks. This was an easier route for the dotnet repo instead of pinvoking.
  • Adds a PlatformFact for xunit, so we can skip tests based on platform

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as all the CI checks are green.

Thanks @aritchie !

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally would go on a major bump because technically breaks saved search and tag distribution based on that OS tag. But I'd say unlikely to be a real disruption and the value of the change is worth the risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS version not reported

4 participants