This repository was archived by the owner on Aug 2, 2021. It is now read-only.
[WIP] Pushsync #1323
Closed
[WIP] Pushsync #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nolash
suggested changes
Apr 12, 2019
Contributor
nolash
left a comment
nolash
left a comment
There was a problem hiding this comment.
The review contains some comments from parts of the diff that is out of scope of the push sync stuff; I didn't realize the scope until later on. Handling them is optional then, I guess.
| Validate(ch Chunk) bool | ||
| } | ||
|
|
||
| // ValidatorStore encapsulates Store by decorting the Put method |
Member
There was a problem hiding this comment.
It is a typo, it should be decorating.
| SubscribePush(context.Context) (<-chan storage.Chunk, func()) | ||
| // called to set a chunk as synced - and allow it to be garbage collected | ||
| // TODO this should take ... last argument to delete many in one batch | ||
| Set(context.Context, chunk.ModeSet, storage.Address) error |
Contributor
There was a problem hiding this comment.
let's set the interface correctly right away, but comment it only handles the first element for now.
Contributor
|
needs rebase @zelig |
…ore db migration (elad) (#1335)
* swarm/shed: remove metrics fields from DB struct * swarm/schunk: add String methods to modes * swarm/storage/localstore: add metrics and traces * swarm/chunk: unknown modes without spaces in String methods * swarm/storage/localstore: remove bin number from pull subscription metrics * swarm/storage/localstore: add resetting time metrics and code improvements
* swarm/chunk: add tags backend to chunk package
swarm/api: integrate tags to count chunks being split and stored swarm/api/http: integrate tags in middleware for HTTP `POST` calls and assert chunks being calculated and counted correctly swarm: remove deprecated and unused code, add swarm hash to DoneSplit signature, remove calls to the api client from the http package
* swarm/storage: remove traces for put/get/set * swarm/storage: remove Has traces
nonsense
force-pushed
the
swarm-rather-stable
branch
from
8817225 to
c98771c
Compare
Member
Author
|
reopen |
nonsense
force-pushed
the
swarm-rather-stable
branch
4 times, most recently
from
ad91427 to
9b1543c
Compare
Closed
3 tasks
Contributor
|
superseded by #1392 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements push syncing protocol in a new package
swarm/storage/pusherThe PR uses the localstore integration branch until it is merged.
The entry point to push sync is the
RunPushSyncfunction which will be called onswarm.golevel.It uses two interfaces:
SubscribePushandSetmethods implements this.pss.PubSubimplements this interfacestorer nodes which accept push synced content will run
RunStoreronswarm.golevelIt obsoletes the earlier #971
and greatly simplifies the code.
It needs: