This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Swarm rather stable: LocalStore metrics #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Apr 23, 2019
nonsense
reviewed
Apr 23, 2019
nonsense
reviewed
Apr 23, 2019
nonsense
reviewed
Apr 23, 2019
nonsense
reviewed
Apr 23, 2019
nonsense
approved these changes
Apr 24, 2019
Contributor
nonsense
left a comment
nonsense
left a comment
There was a problem hiding this comment.
LGTM - counters and resetting timers would def add a lot of value and give us intuition on how fast the localstore is in prod environment.
I am still not sure about the amount of spans that we will add for each trace to OpenTracing, so we might need to revisit this later.
Member
Author
|
Cool, thanks @nonsense. |
nonsense
pushed a commit
that referenced
this pull request
May 10, 2019
* swarm/shed: remove metrics fields from DB struct * swarm/schunk: add String methods to modes * swarm/storage/localstore: add metrics and traces * swarm/chunk: unknown modes without spaces in String methods * swarm/storage/localstore: remove bin number from pull subscription metrics * swarm/storage/localstore: add resetting time metrics and code improvements
nonsense
pushed a commit
that referenced
this pull request
May 10, 2019
* swarm/shed: remove metrics fields from DB struct * swarm/schunk: add String methods to modes * swarm/storage/localstore: add metrics and traces * swarm/chunk: unknown modes without spaces in String methods * swarm/storage/localstore: remove bin number from pull subscription metrics * swarm/storage/localstore: add resetting time metrics and code improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics and traces to the new localstore and removes unneeded metics fields from shed to the scope of meter function.
fixes: #1345