This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm/network: remove FetchStore and SyncChunkStore in favor of NetStore #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janos
approved these changes
Apr 12, 2019
nonsense
added a commit
that referenced
this pull request
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of syncing
simplify-fetchersbranch toswarm-rather-stable, this PR is:FetchStoreinterfaceNetStoreeven though having the wordStorein its name is not a ChunkStore - it has a different behavior, and for now we don't need an interface for it, as we can use the concrete implementation with a different remote fetch function - currently calledFetchFunc, but about to be changed in an upcoming PR.