feat: distributed tracing #524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
BTW, this currently just uses uuid as the span id, but that will change later. This is just to have an ID of some sort to work with, for now. |
Qard
force-pushed
the
distributed-tracing
branch
6 times, most recently
from
460d8fc to
7bac95e
Compare
Contributor
|
@Qard I think it's best if we made this PR against the |
This is a race condition. The tests would call t.end() before all their assertions had finished. This would not be an issue when running the tests normally, but when running via nyc it would fail.
Qard
force-pushed
the
distributed-tracing
branch
from
4171fd5 to
045f57b
Compare
This will instead be handled by the elastic-apm-http-client module in the future.
Qard
force-pushed
the
distributed-tracing
branch
from
045f57b to
6e75667
Compare
Contributor
Author
|
Closing in favor of #538. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an in-progress PR for distributed tracing.
Depends on the api-v2 branch being merged. (No PR number yet)