feat: distributed tracing #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
distributed-tracing
branch
2 times, most recently
from
5c28cc2 to
fe39c08
Compare
Qard
force-pushed
the
distributed-tracing
branch
2 times, most recently
from
eb08831 to
8d08556
Compare
|
Rebased with #557 to get tests passing. |
Qard
force-pushed
the
distributed-tracing
branch
5 times, most recently
from
6c0b200 to
4892168
Compare
Qard
force-pushed
the
distributed-tracing
branch
5 times, most recently
from
4fd6de6 to
011f5d9
Compare
watson
reviewed
Sep 10, 2018
lib/instrumentation/span.js
Outdated
|
|
||
| Object.defineProperty(this, 'id', { | ||
| get () { | ||
| return this.context.id.toString('hex') |
There was a problem hiding this comment.
It's probably best to cache this value. Currently it's not used more than once, but I wouldn't be surprised if we started to output this in logs as well.
There was a problem hiding this comment.
Should probably actually just log the context object, in the future, so the trace id is there too. 🤔
Qard
force-pushed
the
distributed-tracing
branch
from
011f5d9 to
f0dedbc
Compare
|
@watson I made some changes to try having a shared buffer and string getters. |
Qard
force-pushed
the
distributed-tracing
branch
5 times, most recently
from
4a6a1a1 to
8fd0cb9
Compare
Qard
force-pushed
the
distributed-tracing
branch
from
bd05282 to
24d5548
Compare
felixbarny
reviewed
Oct 2, 2018
|
@Qard the merge conflicts look a little bit complicated, so I didn't want to spend too much time on it. I assume you could do it very quickly 😃 |
|
@Qard never mind. I managed to fix the merge conflicts |
watson
approved these changes
Oct 17, 2018
watson
pushed a commit
that referenced
this pull request
Oct 19, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Oct 27, 2018
Qard
added a commit
that referenced
this pull request
Oct 31, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 6, 2018
watson
pushed a commit
that referenced
this pull request
Nov 6, 2018
Qard
added a commit
that referenced
this pull request
Nov 8, 2018
watson
pushed a commit
that referenced
this pull request
Nov 10, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
watson
pushed a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retargetting #524 to api-v2...
Fixes #421