docs: add api docs for apiRequestTime and apiRequestSize #499
+75
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
commented
Aug 6, 2018
|
|
||
| [float] | ||
| [[performance-transaction-queue]] | ||
| === Transaction Queue |
There was a problem hiding this comment.
@Qard are you ok with removing this entire section without replacing it with anything else?
There was a problem hiding this comment.
We should probably replace it with a new section describing how apiRequestTime and apiRequestSize will impact the performance.
|
The CI failures are because of the npm bug with the github link in the dependencies |
watson
commented
Aug 7, 2018
docs/performance-tuning.asciidoc
Outdated
|
|
||
| The agent uses a persistent outgoing HTTP request to stream data to the APM Server. | ||
| To avoid issues with intermittent proxies and load balancers, | ||
| the HTTP request is ended and a new one created at regular intervals or when the size of the reqeust becomes too big. |
Qard
reviewed
Aug 7, 2018
docs/performance-tuning.asciidoc
Outdated
| Using the <<api-request-size,`apiRequestSize`>> config option, | ||
| this time limit can be modified. | ||
|
|
||
| Lowering the size limit might be nessecary if dealing with very agressive proxies, |
Qard
approved these changes
Aug 8, 2018
|
There seems to be an asciidoc error. 🤔 |
watson
added a commit
that referenced
this pull request
Aug 9, 2018
watson
added a commit
that referenced
this pull request
Aug 10, 2018
watson
added a commit
that referenced
this pull request
Aug 29, 2018
watson
added a commit
that referenced
this pull request
Aug 30, 2018
watson
added a commit
that referenced
this pull request
Sep 6, 2018
watson
added a commit
that referenced
this pull request
Sep 13, 2018
watson
added a commit
that referenced
this pull request
Oct 19, 2018
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Oct 27, 2018
Qard
pushed a commit
that referenced
this pull request
Oct 31, 2018
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 6, 2018
watson
added a commit
that referenced
this pull request
Nov 6, 2018
Qard
pushed a commit
that referenced
this pull request
Nov 8, 2018
watson
added a commit
that referenced
this pull request
Nov 10, 2018
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for intake API v2