Enable full solution background analysis

[mavasani]

Closes dotnet/roslyn#68553

• Adds 2 new background analysis scope options: one for compiler diagnostics and one for analyzer diagnostics (options match VS)
• Both the options allow the same set of values as in VS: Open documents, Entire solution, Current document and None (disabled). Currently, Current document option is not yet supported in LSP as we do not have a way to know which is the current active document in LSP server.
• Builds on top of Roslyn side changes to enable full solution background analysis in LSP/VSCode roslyn#68799
• Needs couple more Roslyn side changes as a follow-up: WorkspacePullDiagnosticHandler should handle background analysis scope options for both compiler and analyzer diagnostics roslyn#68797 and LSP pull diagnostic handlers should handle None/Disabled option value for compiler and analyzer background analysis options roslyn#68798

[mavasani]

Enum values match Roslyn side enum names: https://github.com/dotnet/roslyn/blob/bdbf1cb87abc8f9554ee331a1113d533ae5ec5fb/src/Workspaces/Core/Portable/SolutionCrawler/BackgroundAnalysisScope.cs#L7-L34

[mavasani]

Descriptions match VS side descriptions in Tools Options dialog

[CyrusNajmabadi]

I agree that we should not talk about solution crawling.

[mavasani]

I agree that we should not talk about solution crawling.

This has now been fixed.

[dibarbet]

@Cosifne if this merges without the server side change to enable the option, will that cause errors?

[arunchndr]

@Cosifne if this merges without the server side change to enable the option, will that cause errors?

Good point. Here is the server version that needs to be taken in - 4.7.0-3.23328.2.

[Cosifne]

@Cosifne if this merges without the server side change to enable the option, will that cause errors?

If client change goes in before server change.
It will act like the user can specify a value in the client, but there is no effect.

If server change goes in before client change.
Server would keep asking the client the value of the option, but client would always return string.Empty to server.

[mavasani]

@Cosifne @dibarbet are we okay to merge this?

[dibarbet]

@mavasani since it looks like the main roslyn side PRs are merged, would you mind updating the roslyn version as well in the PR, so that it all works end to end? Instructions here - https://github.com/dotnet/vscode-csharp/blob/main/CONTRIBUTING.md#updating-the-roslyn-server-version (let me know if they're good instructions)

No worries if not, Shen mentioned nothing should break if the roslyn version isn't updated, and I can update later this week

[mavasani]

@mavasani since it looks like the main roslyn side PRs are merged, would you mind updating the roslyn version as well in the PR, so that it all works end to end? Instructions here - https://github.com/dotnet/vscode-csharp/blob/main/CONTRIBUTING.md#updating-the-roslyn-server-version (let me know if they're good instructions)

No worries if not, Shen mentioned nothing should break if the roslyn version isn't updated, and I can update later this week

Thanks Dave. I tried those steps but gulp installDependencies --interactive still fails to find the new package (I tried a signed build from 24 hours ago, still no luck). I did perform the authentication step, which succeeded but still unable to find the package:

C:\Program Files\dotnet\sdk\8.0.100-preview.5.23303.2\NuGet.targets(156,5): error : Failed to download package 'Microso
ft.CodeAnalysis.LanguageServer.4.7.0-3.23328.5' from 'https://pkgs.dev.azure.com/azure-public/3ccf6661-f8ce-4e8a-bb2e-e
ff943ddd3c7/_packaging/36a629e1-6c5b-4bcd-aa2e-6018802d6b99/nuget/v3/flat2/microsoft.codeanalysis.languageserver/4.7.0-
3.23328.5/microsoft.codeanalysis.languageserver.4.7.0-3.23328.5.nupkg'. [c:\vscode-csharp\server\ServerDownload.csproj]
C:\Program Files\dotnet\sdk\8.0.100-preview.5.23303.2\NuGet.targets(156,5): error : Response status code does not indic
ate success: 401 (Unauthorized - No local versions of package 'microsoft.codeanalysis.languageserver'; please provide a
uthentication to access versions from upstream that have not yet been saved to your feed. (DevOps Activity ID: DA658997
-7077-4FEC-BA50-3469AEDE9730)). [c:\vscode-csharp\server\ServerDownload.csproj]
C:\Program Files\dotnet\sdk\8.0.100-preview.5.23303.2\NuGet.targets(156,5): error : Central Directory corrupt. [c:\vsco
de-csharp\server\ServerDownload.csproj]
C:\Program Files\dotnet\sdk\8.0.100-preview.5.23303.2\NuGet.targets(156,5): error :   The parameter is incorrect. : 'c:
\vscode-csharp\out\.nuget\microsoft.codeanalysis.languageserver\4.7.0-3.23328.5\fzqkzsy1.yj1' [c:\vscode-csharp\server\
ServerDownload.csproj]
[08:33:12] 'installDependencies' errored after 1.3 min
[08:33:12] Error: Failed to download nuget package microsoft.codeanalysis.languageserver.4.7.0-3.23328.5
    at ChildProcess.<anonymous> (c:\vscode-csharp\tasks\offlinePackagingTasks.ts:163:23)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess.emit (node:domain:552:15)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
    at Process.callbackTrampoline (node:internal/async_hooks:130:17)

[CyrusNajmabadi]

would have loved the descriptions and the enum member names to match :)

[mavasani]

These match the enum field names and user facing descriptions in VS. I think it would be reasonable to change the enum field names in Roslyn, and once the new values flow into this repo, we can rename the field names here as well. However, these are just internal implementation details, so not sure if it critical to make these changes.