Address feedback and also fix linting issues

Author: mavasani

src/lsptoolshost/optionNameConverter.ts

@@ -29,13 +29,7 @@ export function convertServerOptionNameToClientConfigurationName(section: string
         const prefixes = ['dotnet', 'csharp'];
         const optionNamePrefix = getPrefix(optionName, prefixes);
 
-        let featureName = optionNamePrefix == '' ? optionName: optionName.substring(optionNamePrefix.length + 1);
-        
-        // Handle special case for background analysis option: we want to avoid
-        // 'solution crawler' terminology in the user facing VSCode option.
-        if (featureName =="solution_crawler_background_analysis_scope") {
-            featureName = "analyzer_diagnostics_scope";
-        }
+        const featureName = optionNamePrefix == '' ? optionName : optionName.substring(optionNamePrefix.length + 1);
 
         // Finally, convert everything to camel case and put them together.
         const camelCaseGroupName = convertToCamelCase(optionGroupName, '_');

test/unitTests/lspToolHost/configurationMiddleware.test.ts

@@ -190,24 +190,24 @@ const testData = [
         declareInPackageJson: false,
     },
     {
-        serverOption: "csharp|background_analysis.dotnet_solution_crawler_background_analysis_scope",
-        vsCodeConfiguration: "dotnet.backgroundAnalysis.analyzerDiagnosticsScope",
-        declareInPackageJson: true
+        serverOption: 'csharp|background_analysis.dotnet_analyzer_diagnostics_scope',
+        vsCodeConfiguration: 'dotnet.backgroundAnalysis.analyzerDiagnosticsScope',
+        declareInPackageJson: true,
     },
     {
-        serverOption: "mystery_language|background_analysis.dotnet_solution_crawler_background_analysis_scope",
+        serverOption: 'mystery_language|background_analysis.dotnet_analyzer_diagnostics_scope',
         vsCodeConfiguration: null,
-        declareInPackageJson: false
+        declareInPackageJson: false,
     },
     {
-        serverOption: "csharp|background_analysis.dotnet_compiler_diagnostics_scope",
-        vsCodeConfiguration: "dotnet.backgroundAnalysis.compilerDiagnosticsScope",
-        declareInPackageJson: true
+        serverOption: 'csharp|background_analysis.dotnet_compiler_diagnostics_scope',
+        vsCodeConfiguration: 'dotnet.backgroundAnalysis.compilerDiagnosticsScope',
+        declareInPackageJson: true,
     },
     {
-        serverOption: "mystery_language|background_analysis.dotnet_compiler_diagnostics_scope",
+        serverOption: 'mystery_language|background_analysis.dotnet_compiler_diagnostics_scope',
         vsCodeConfiguration: null,
-        declareInPackageJson: false
+        declareInPackageJson: false,
     },
 ];