Enabling solution wide analysis attempts to compute diagnostics for non-source files

[mavasani]

#5868 enables solution wide analysis. Once enabled, we seem to be attempting to calculate diagnostics in non-source files: see nodes for exec and csc.dll below

Repro project: TestEFApp.zip

Looking under the debugger, it seems we might be adding invalid documents to the project:

[dibarbet]

That's uh... quite weird. Did you only see it with that repro project, or others as well? Will take a look

[dibarbet]

Also @mavasani - were you running with devkit as well?

[mavasani]

That's uh... quite weird. Did you only see it with that repro project, or others as well? Will take a look

Seems to be happening for all projects. There is one error per-project in the solution:

were you running with devkit as well?

I am running with latest Roslyn language server bits + checkout out #5868 and executed F5 and enabled FSA for both compiler and analyzer diagnostics.

[mavasani]

Also @mavasani - were you running with devkit as well?

@dibarbet Disabling C# dev kit indeed removed these spurious errors.

[mavasani]

The project system is handing us these additional non-source files as source files when adding generated code files.

When I disable C# dev kit, I notice that exec and c:\Program Files\dotnet\sdk\8.0.100-preview.5.23303.2\Roslyn\bincore\csc.dll are both passed as command line arguments, but not classified or added as source files. I presume this might be an issue with the MSBuild target that extracts source files out of the command line arguments in context of C# dev kit.

[dibarbet]

Thanks for confirming. I'm going to move this over to the devkit side. Tagging @tmeschter