First pass at source build pre-built detection #31341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A first pass at source built prebuilt detection. Currently depends on: - An arcade update that is still in flight (dotnet#30845) - Workaround of a p1 roslyn-analzyers bug (fixed in p3 supposedly) Enable pre-built detection, without being completely clean. Add dependencies and enable source-build elements where needed. There are a variety of prebuilts that need additional investigation. Likely they will either be SBRPs, upgraded, or perhaps permanantly excluded from detection (e.g. Microsoft.NETCore.App.Ref 6.0 packages).
ghost
added
the
|
I believe this will fail until issues in #30845 are resolved and that is merged. |
MichaelSimons
approved these changes
Mar 29, 2023
|
Yep I'll add comments and get this checked in tomorrow. |
|
|
||
| <!-- TODO: Figure out what to do about the netcoreapp ref packages (these are probably being pulled | ||
| in via implicit versions and net6 targeting projects (e.g. tests) | ||
| https://github.com/dotnet/source-build/issues/3356 --> |
There was a problem hiding this comment.
After investigating, this is caused from #30272.
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first pass at source built prebuilt detection. Currently depends on:
Enable pre-built detection, without being completely clean. Add dependencies and enable source-build elements where needed. There are a variety of prebuilts that need additional investigation. Likely they will either be SBRPs, upgraded, or perhaps permanantly excluded from detection (e.g. Microsoft.NETCore.App.Ref 6.0 packages).