Skip to content

First pass at source build pre-built detection #31341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 3, 2023
Merged

First pass at source build pre-built detection #31341

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
47bad06
First pass at source build pre-built detection
mmitche Mar 21, 2023
02621e0
Merge branch 'main' into enable-prebuilt-detection
mmitche Mar 28, 2023
32aa8ac
Revert changes
mmitche Mar 28, 2023
a3030b2
Merge remote-tracking branch 'origin/enable-prebuilt-detection' into …
mmitche Mar 28, 2023
5ab2654
Re-add source link deps
mmitche Mar 28, 2023
2e3ee38
Resolve conflicts and add issue links
mmitche Mar 31, 2023
1697e47
Update coherency
mmitche Mar 31, 2023
c942623
Disable ref pack exclusion
mmitche Mar 31, 2023
793a1f6
Re-enable ref pack exclusion
mmitche Apr 3, 2023
fe1c658
Re-enable razor exclusion
mmitche Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
<!-- Disable implict package target fallback, and disable warning for when we explicitly add it (currently needed for
Microsoft.ApplicationInsights) -->
<NoWarn>$(NoWarn);NU1701</NoWarn>
<!-- Temporarily NoWarn to avoid regression in preview 1.
https://github.com/dotnet/roslyn-analyzers/pull/6236/files -->
<NoWarn>$(NoWarn);CA2009</NoWarn>
<!-- do not enable analyzers on source build-->
<EnforceCodeStyleInBuild Condition="'$(DotNetBuildFromSource)' != 'true'">true</EnforceCodeStyleInBuild>
<DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>
Expand Down
64 changes: 63 additions & 1 deletion eng/SourceBuildPrebuiltBaseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,67 @@
<UsageData>
<IgnorePatterns>
<UsagePattern IdentityGlob="*/*" />
<UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" />

<!-- TODO: Ignore needed until https://github.com/NuGet/Home/issues/11059 is addressed. -->
<UsagePattern IdentityGlob="Nuget.*/*" />
<UsagePattern IdentityGlob="Microsoft.Build.NuGetSdkResolver/*" />

<!-- TODO: Ignore needed until vstest gets a source build leg. -->
<UsagePattern IdentityGlob="Microsoft.TestPlatform.*/*" />

<!-- TODO: Ignore needed until razor merges main into the 17.6 branch -->
<UsagePattern IdentityGlob="Microsoft*Razor.*/*" />

<!-- TODO: Figure out what to do about the netcoreapp ref packages (these are probably being pulled
in via implicit versions and net6 targeting projects (e.g. tests) -->
<UsagePattern IdentityGlob="Microsoft.*.App.Ref/*6.0*" />

<!-- TODO: SBRPs or updates -->
<UsagePattern IdentityGlob="Microsoft.ApplicationInsights/*2.19.0*" />
<UsagePattern IdentityGlob="Microsoft.Bcl.AsyncInterfaces/*6.0.0*" />
<UsagePattern IdentityGlob="Microsoft.Build*/*16.11.0*" />
<UsagePattern IdentityGlob="Microsoft.Build.Locator/*1.5.3*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.AnalyzerUtilities/*3.3.0*" />\
<UsagePattern IdentityGlob="Microsoft.Css.Parser/*1.0.0-20200708.1*" />
<UsagePattern IdentityGlob="Microsoft.DiaSymReader/*1.4.0*" />
<UsagePattern IdentityGlob="Microsoft.Extensions.*/*6.0.0*" />
<UsagePattern IdentityGlob="Microsoft.NET.StringTools/*1.0.0*" />
<UsagePattern IdentityGlob="Microsoft.Win32.SystemEvents/*7.0.0*" />
<UsagePattern IdentityGlob="System.CodeDom/*7.0.0*" />
<UsagePattern IdentityGlob="System.Collections.Immutable/*7.0.0*" />
<UsagePattern IdentityGlob="System.Composition*/*6.0.0*" />
<UsagePattern IdentityGlob="System.Collections.Immutable.*/*7.0.0*" />
<UsagePattern IdentityGlob="System.Configuration.ConfigurationManager/*4.7.0*" />
<UsagePattern IdentityGlob="System.Configuration.ConfigurationManager/*7.0.0*" />
<UsagePattern IdentityGlob="System.Diagnostics.DiagnosticSource/*6.0.0*" />
<UsagePattern IdentityGlob="System.Diagnostics.EventLog/*7.0.0*" />
<UsagePattern IdentityGlob="System.Drawing.Common/*7.0.0*" />
<UsagePattern IdentityGlob="System.Formats.Asn1/*7.0.0*" />
<UsagePattern IdentityGlob="System.IO.Pipelines/*6.0.3*" />
<UsagePattern IdentityGlob="System.Reflection.Metadata*/*7.0.0*" />
<UsagePattern IdentityGlob="System.Resources.Extensions/*7.0.0*" />
<UsagePattern IdentityGlob="System.Security.Cryptography.Pkcs/*7.0.0*" />
<UsagePattern IdentityGlob="System.Security.Cryptography.ProtectedData/*4.7.0*" />
<UsagePattern IdentityGlob="System.Security.Cryptography.ProtectedData/*7.0.0*" />
<UsagePattern IdentityGlob="System.Security.Cryptography.Xml/*4.7.0*" />
<UsagePattern IdentityGlob="System.Security.Cryptography.Xml/*7.0.1*" />
<UsagePattern IdentityGlob="System.Security.Permissions/*7.0.0*" />
<UsagePattern IdentityGlob="System.ServiceProcess.ServiceController/*7.0.0*" />
<UsagePattern IdentityGlob="System.Text.Encoding.CodePages/*6.0.0*" />
<UsagePattern IdentityGlob="System.Text.Encoding.CodePages/*7.0.0*" />
<UsagePattern IdentityGlob="System.Text.Encodings.Web/*6.0.0*" />
<UsagePattern IdentityGlob="System.Text.Encodings.Web/*7.0.0*" />
<UsagePattern IdentityGlob="System.Text.Json/*6.0.0*" />
<UsagePattern IdentityGlob="System.Text.Json/*7.0.0*" />
<UsagePattern IdentityGlob="System.Text.Json/*7.0.1*" />
<UsagePattern IdentityGlob="System.Text.Json/*7.0.2*" />
<UsagePattern IdentityGlob="System.Security.Permissions/*7.0.0*" />
<UsagePattern IdentityGlob="System.Threading.Channels/*6.0.0*" />
<UsagePattern IdentityGlob="System.Threading.Tasks.Dataflow/*7.0.0*" />
<UsagePattern IdentityGlob="System.Windows.Extensions/*7.0.0*" />

<!-- This may be coming in transitively from aspnetcore. Needs evaluation -->
<UsagePattern IdentityGlob="System.Text.Json/*8.0.0*" />
<UsagePattern IdentityGlob="System.Text.Encodings.Web/*8.0.0*" />
</IgnorePatterns>
</UsageData>
14 changes: 13 additions & 1 deletion eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.8.0" Version="8.0.0-preview.4.23177.1">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>beb708f6fe999cbbe5542846c9985ce596569097</Sha>
<SourceBuild RepoName="runtime" ManagedOnly="false" />
</Dependency>
<Dependency Name="VS.Redist.Common.NetCore.TargetingPack.x64.8.0" Version="8.0.0-preview.4.23177.1">
<Uri>https://github.com/dotnet/runtime</Uri>
Expand Down Expand Up @@ -45,6 +46,7 @@
<Dependency Name="Microsoft.Build" Version="17.6.0-preview-23174-01">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>e7de1330724224a542668e1ef82c997613c7080c</Sha>
<SourceBuild RepoName="msbuild" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.Build.Localization" Version="17.6.0-preview-23174-01">
<Uri>https://github.com/dotnet/msbuild</Uri>
Expand All @@ -62,7 +64,7 @@
<Dependency Name="dotnet-format" Version="8.0.416301">
<Uri>https://github.com/dotnet/format</Uri>
<Sha>0b968051beac5d7c1a62a52aee7fbbbb47dc1f47</Sha>
<SourceBuildTarball RepoName="format" ManagedOnly="true" />
<SourceBuild RepoName="format" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.6.0-2.23177.13">
<Uri>https://github.com/dotnet/roslyn</Uri>
Expand Down Expand Up @@ -255,6 +257,11 @@
<Sha>4b8fe3ff0cfb2b38901803c798c647ca8123c222</Sha>
<SourceBuild RepoName="source-build-externals" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.23156.5">
<Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
<Sha>e2279a0388f89a1f771ff7e4ded01f0e657bcafb</Sha>
<SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.Deployment.DotNet.Releases" Version="1.0.0-preview6.1.23159.4">
<Uri>https://github.com/dotnet/deployment-tools</Uri>
<Sha>b60c95e1ce736630d17e16626c59e3dd85ebae2b</Sha>
Expand All @@ -273,6 +280,11 @@
<Sha>1177b37e60c7271ab461098aefbdd03edc15b90d</Sha>
<SourceBuild RepoName="arcade" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.SourceLink.GitHub" Version="1.2.0-beta-23172-02" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Uri>https://github.com/dotnet/sourcelink</Uri>
<Sha>a86ac5afc76f4afbd3dd59029a00857cc3eeb6e3</Sha>
<SourceBuild RepoName="sourcelink" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="8.0.0-beta.23174.1">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>1177b37e60c7271ab461098aefbdd03edc15b90d</Sha>
Expand Down