Skip to content

[main] Update dependencies from dotnet/msbuild #31599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 6, 2023
Merged

[main] Update dependencies from dotnet/msbuild #31599

merged 5 commits into from
Apr 6, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 4, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
  • Build: 20230404.3
  • Date Produced: April 4, 2023 7:57:18 AM UTC
  • Commit: 413571dea9ebb0023f26e5c0f5cd514d30b61465
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
aa92111 
…0404.3

Microsoft.Build , Microsoft.Build.Localization
 From Version 17.6.0-preview-23174-01 -> To Version 17.7.0-preview-23204-03
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Apr 4, 2023
@nagilson
Copy link
Member

nagilson commented Apr 4, 2023

@dotnet/msbuild PTAL at this source build error: 2 new pre-builts discovered. The link given for aka ms prebuilds is dead.

@nagilson
Copy link
Member

nagilson commented Apr 4, 2023

Hmm actually its happening in other PRs too. Care to take a look @dotnet/source-build-contrib ?

@nagilson nagilson mentioned this pull request Apr 4, 2023
Merged
@MichaelSimons
Copy link
Member

MichaelSimons commented Apr 4, 2023

Hmm actually its happening in other PRs too. Care to take a look @dotnet/source-build-contrib ?

@mmitche - This is related to your changes in #31341.

There are two prebuilts

  1. Microsoft.Build.NoTargets.3.7.0
    This exists in SBRP. SDK just needs a newer version. It looks like a darc subscription wasn't added for this. The version you took a dependency on is a month old.
  2. Microsoft.CodeAnalysis.PublicApiAnalyzers.3.3.4
    I don't know about this one. Smells like a reference that should be excluded for source-build.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
2afa743 
…ence-packages build 20230404.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23156.5 -> To Version 8.0.0-alpha.1.23204.3
@nagilson nagilson mentioned this pull request Apr 5, 2023
Merged
mmitche added 2 commits April 5, 2023 15:59
@mmitche
Add a dependency for PublicApiAnalyzers and use that for containers proj
7ffe593 
We should use the same version as the roslyn-analyzers version we are shipping. This is also required for source-build.
@mmitche
Merge branch 'darc-main-de8ee925-5c0c-468c-8f13-d5188969fdcd' into da…
4b5934d 
…rc-main-46fc2f99-5259-4d9d-a855-013a615a5ecb
@mmitche
Copy link
Member

mmitche commented Apr 5, 2023

Also merged the changes from the SBRP PR to verify.

@nagilson nagilson enabled auto-merge April 5, 2023 23:17
@nagilson
Copy link
Member

nagilson commented Apr 5, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 5, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@nagilson nagilson merged commit 48f77fa into main Apr 6, 2023
@nagilson nagilson deleted the darc-main-46fc2f99-5259-4d9d-a855-013a615a5ecb branch April 6, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagilson nagilson nagilson approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nagilson @MichaelSimons @mmitche