Enable TFM filtering by default #13271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| This is fed into the inner source build as an environment variable (DotNetTargetFrameworkFilter) to enable filtering. | ||
| The default target framework filter includes all recent netcoreapps in SBRP, as well as 8.0 (latest) and 7.0 (working to get rid of it. | ||
| TFM filtering is enabled by default and can be disabled, at repo level, by setting NoTargetFrameworkFiltering property to true, |
Member
There was a problem hiding this comment.
I am curious why this needs to be set in the repo's root Directory.Build.props file. It seems preferrable in the SourceBuild.props.
Member
There was a problem hiding this comment.
Please see discussion in dotnet/runtime#84811 (comment)
MichaelSimons
approved these changes
Apr 24, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#3362
Enables TFM filtering by default. Repos can opt-out by adding
NoTargetFrameworkFilteringproperty to repo's rootDirectory.Build.propsfile and setting the value totrue.CAUTION: this should not be merged before dotnet/installer#16214 gets merged.