TFM trimming - emsdk - Move NoTargetFrameworkFiltering property to Directory.Build.props #16214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| + <PropertyGroup> | ||
| + <!-- Emsdk doesn't support Arcade-driven target framework filtering. --> | ||
| + <NoTargetFrameworkFiltering>true</NoTargetFrameworkFiltering> |
Member
There was a problem hiding this comment.
I am curious why this needs to be set in the repo's root Directory.Build.props file. It seems preferrable in the SourceBuild.props.
MichaelSimons
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for this issue: dotnet/source-build#3417
NoTargetFrameworkFilteringproperty, inemsdkrepo, should be moved fromeng/SourceBuild.propstoDirectory.Build.props. Without this change, switching to opt-out TFM model (dotnet/source-build#3362) would cause allemsdkprojects to get excluded from the build.This would match the implementation in the
runtimerepo (https://github.com/dotnet/runtime/blob/018a9bd43851c998f9239aedf2fcc09c5eff7488/Directory.Build.props#L304-L305).This change is a prerequisite for dotnet/arcade#13271