-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Opt-out of default target framework filtering in source-build infra #84811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-out of default target framework filtering in source-build infra #84811
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details
We plan to switch the filtering logic to be on by default, and require repos to explicitly opt-out, see dotnet/source-build#3362 'runtime' is already filtering target frameworks using a custom model, and this work will not have an impact: #83899
|
eng/SourceBuild.props
Outdated
|
|
||
| <PropertyGroup> | ||
| <GitHubRepositoryName>runtime</GitHubRepositoryName> | ||
| <NoTargetFrameworkFiltering>true</NoTargetFrameworkFiltering> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this here:
Line 293 in 2d9cb2d
| <PropertyGroup> |
Otherwise target framework filtering could happen outside of the "-sb" build when passing /p:DotNetBuildFromSource=true in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that ArcadeBuildFromSource was basically the default at this point and that source build was not generally functional without it. That switch would bring in this file. @dotnet/source-build-internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux partners actively use the /p:DotNetBuildFromSource switch in their CI, cc @tmds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are usually used as a combo though, I think? Otherwise SourceBuild.props wouldn't be the place to put any source build specific properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, they use the source build switch without depending on Arcade powered source build. See #81480 for more details
runtimedoesn't use target framework filtering in source-build infra.We plan to switch the filtering logic to be on by default, and require repos to explicitly opt-out, see dotnet/source-build#3362
'runtime' is already filtering target frameworks using a custom model, and this work will not have an impact: #83899