Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

runtime doesn't use target framework filtering in source-build infra.

We plan to switch the filtering logic to be on by default, and require repos to explicitly opt-out, see dotnet/source-build#3362

'runtime' is already filtering target frameworks using a custom model, and this work will not have an impact: #83899

@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

runtime doesn't use target framework filtering in source-build infra.

We plan to switch the filtering logic to be on by default, and require repos to explicitly opt-out, see dotnet/source-build#3362

'runtime' is already filtering target frameworks using a custom model, and this work will not have an impact: #83899

Author: NikolaMilosavljevic
Assignees: NikolaMilosavljevic
Labels:

area-Infrastructure-libraries

Milestone: -


<PropertyGroup>
<GitHubRepositoryName>runtime</GitHubRepositoryName>
<NoTargetFrameworkFiltering>true</NoTargetFrameworkFiltering>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this here:

<PropertyGroup>

Otherwise target framework filtering could happen outside of the "-sb" build when passing /p:DotNetBuildFromSource=true in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that ArcadeBuildFromSource was basically the default at this point and that source build was not generally functional without it. That switch would bring in this file. @dotnet/source-build-internal?

Copy link
Member

@ViktorHofer ViktorHofer Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux partners actively use the /p:DotNetBuildFromSource switch in their CI, cc @tmds

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are usually used as a combo though, I think? Otherwise SourceBuild.props wouldn't be the place to put any source build specific properties.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, they use the source build switch without depending on Arcade powered source build. See #81480 for more details

@NikolaMilosavljevic NikolaMilosavljevic merged commit 87ba6ea into dotnet:main Apr 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants