Fixing incorrect event id and opcode for the SqlEventSource. #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Oct 3, 2019
cijothomas
approved these changes
Oct 3, 2019
cheenamalhotra
approved these changes
Oct 3, 2019
yukiwongky
pushed a commit
to yukiwongky/SqlClient
that referenced
this pull request
Nov 5, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect event ids are defined on the BeginExecuteEventId, resulting in in errors when WriteEvent is called for the Event Source. That again results in for example Application Insights being unable to properly track SQL dependency calls made with Microsoft.Data.SqlClient.
See this issue for reference: https://github.com/microsoft/ApplicationInsights-dotnet-server/issues/1282