Fix | Fixing incorrect event id and opcode for the SqlEventSource. (#241)

stebet · cheenamalhotra · commit de6e901c8c24 · 2019-10-03T17:11:15.000-07:00
diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlEventSource.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlEventSource.cs
@@ -51,7 +51,7 @@ private SqlEventSource()
         // the EventSource activity IDs (because they currently don't use tasks and this simply confuses the logic) and 
         // because of versioning requirements we don't have ActivityOptions capability (because mscorlib and System.Data version 
         // at different rates)  Sigh...
-        [Event(SqlEventSource.EndExecuteEventId, Keywords = Keywords.SqlClient, Task = Tasks.ExecuteCommand, Opcode = EventOpcode.Stop)]
+        [Event(SqlEventSource.BeginExecuteEventId, Keywords = Keywords.SqlClient, Task = Tasks.ExecuteCommand, Opcode = EventOpcode.Start)]
         public void BeginExecute(int objectId, string dataSource, string database, string commandText)
         {
             // we do not use unsafe code for better performance optization here because optimized helpers make the code unsafe where that would not be the case otherwise. 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ private SqlEventSource()`
`51`	`51`	`// the EventSource activity IDs (because they currently don't use tasks and this simply confuses the logic) and`
`52`	`52`	`// because of versioning requirements we don't have ActivityOptions capability (because mscorlib and System.Data version`
`53`	`53`	`// at different rates) Sigh...`
`54`		`- [Event(SqlEventSource.EndExecuteEventId, Keywords = Keywords.SqlClient, Task = Tasks.ExecuteCommand, Opcode = EventOpcode.Stop)]`
	`54`	`+ [Event(SqlEventSource.BeginExecuteEventId, Keywords = Keywords.SqlClient, Task = Tasks.ExecuteCommand, Opcode = EventOpcode.Start)]`
`55`	`55`	`public void BeginExecute(int objectId, string dataSource, string database, string commandText)`
`56`	`56`	`{`
`57`	`57`	`// we do not use unsafe code for better performance optization here because optimized helpers make the code unsafe where that would not be the case otherwise.`