Skip to content

Fixing incorrect event id and opcode for the SqlEventSource. #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Fixing incorrect event id and opcode for the SqlEventSource. #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private SqlEventSource()
// the EventSource activity IDs (because they currently don't use tasks and this simply confuses the logic) and
// because of versioning requirements we don't have ActivityOptions capability (because mscorlib and System.Data version
// at different rates) Sigh...
[Event(SqlEventSource.EndExecuteEventId, Keywords = Keywords.SqlClient, Task = Tasks.ExecuteCommand, Opcode = EventOpcode.Stop)]
[Event(SqlEventSource.BeginExecuteEventId, Keywords = Keywords.SqlClient, Task = Tasks.ExecuteCommand, Opcode = EventOpcode.Start)]
public void BeginExecute(int objectId, string dataSource, string database, string commandText)
{
// we do not use unsafe code for better performance optization here because optimized helpers make the code unsafe where that would not be the case otherwise.
Expand Down