Mongo 4 no roles check

[aljones15]

1. Removes the roles check for ./lib/authn.js
2. Throws if the server version is less than 3.6.0 (this was tested and was the lowest mongo node 4 goes)
3. Ups the default server version to 4.4

TODO:

• Test with mongodb server v3
• Test with mongodb server v2

Node Driver compatibility matrix is here: https://www.mongodb.com/docs/drivers/node/current/compatibility/#mongodb-compatibility

3.6 seems to be the lowest.

[codecov-commenter]

Codecov Report

Merging #94 (d64005d) into mongo-driver-4-rc (1b4c0e6) will decrease coverage by 0.41%.
The diff coverage is 30.76%.

@@                  Coverage Diff                  @@
##           mongo-driver-4-rc      #94      +/-   ##
=====================================================
- Coverage              87.08%   86.66%   -0.42%     
=====================================================
  Files                      8        8              
  Lines                    813      810       -3     
=====================================================
- Hits                     708      702       -6     
- Misses                   105      108       +3     

Impacted Files	Coverage Δ
lib/authn.js	75.00% <25.00%> (-2.05%)	⬇️
lib/config.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mattcollier]

Isn't a different version being required by code changes elsewhere in this PR?

[aljones15]

The driver only goes down to 3.6 now: https://www.mongodb.com/docs/drivers/node/current/compatibility/#mongodb-compatibility

So 3.6 is the hard limit on server version.

You can see the 2 checks are here:

bedrock-mongodb/lib/authn.js

Lines 152 to 180 in daa4ce3

	function _checkServerVersion({serverInfo, config}) {
	// check that server version is supported
	const {version} = serverInfo;
	logger.info('connected to database', {
	url: urls.sanitize(config.url),
	version,
	});
	// if the server is not at least 3.6.0 throw
	// as mongo node driver 4 only supports 3.6.0 and higher
	if(!semver.gte(version, '3.6.0')) {
	throw new BedrockError(
	'Unsupported database version.',
	'NotSupportedError', {
	url: urls.sanitize(config.url),
	version,
	required: '>= 3.6.0'
	});
	}
	if(config.requirements.serverVersion &&
	!semver.satisfies(version, config.requirements.serverVersion)) {
	throw new BedrockError(
	'Unsupported database version.',
	'NotSupportedError', {
	url: urls.sanitize(config.url),
	version,
	required: config.requirements.serverVersion
	});
	}
	}

[mattcollier]

Is 4.4 a requirement? We do still have some clusters on Atlas that are 4.2.x.

[aljones15]

Ok so 4.4 is the recommended min version, you can set the serverVersion as low as 3.6. See the compatibility matrix here: https://www.mongodb.com/docs/drivers/node/current/compatibility/#mongodb-compatibility

You can see the two checks here:

bedrock-mongodb/lib/authn.js

Lines 152 to 180 in daa4ce3

	function _checkServerVersion({serverInfo, config}) {
	// check that server version is supported
	const {version} = serverInfo;
	logger.info('connected to database', {
	url: urls.sanitize(config.url),
	version,
	});
	// if the server is not at least 3.6.0 throw
	// as mongo node driver 4 only supports 3.6.0 and higher
	if(!semver.gte(version, '3.6.0')) {
	throw new BedrockError(
	'Unsupported database version.',
	'NotSupportedError', {
	url: urls.sanitize(config.url),
	version,
	required: '>= 3.6.0'
	});
	}
	if(config.requirements.serverVersion &&
	!semver.satisfies(version, config.requirements.serverVersion)) {
	throw new BedrockError(
	'Unsupported database version.',
	'NotSupportedError', {
	url: urls.sanitize(config.url),
	version,
	required: config.requirements.serverVersion
	});
	}
	}

[dlongley]

Closing in favor of #107.