Update to driver v6. #107
Update to driver v6. #107
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 88.79% 87.56% -1.23%
==========================================
Files 8 8
Lines 937 909 -28
==========================================
- Hits 832 796 -36
- Misses 105 113 +8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| config.mongodb.requirements = {}; | ||
| // server version requirement with server-style string | ||
| config.mongodb.requirements.serverVersion = '>=4.2'; | ||
| config.mongodb.requirements.serverVersion = '>=5'; |
There was a problem hiding this comment.
The docs and tests are using v6. Is there a reason to have this lower?
There was a problem hiding this comment.
Yes, there is software out there still using 5 for which this works -- we can bump it further in the future to avoid additional blockers on getting this update through.
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
There was a problem hiding this comment.
@BigBlueHat I recall the license tooling added these blank lines? Do they need to be preserved?
There was a problem hiding this comment.
No, in fact, the licensing tool should not be inserting them.
There was a problem hiding this comment.
I don't think it was a choice, similar to the extra spaces in the copyright date range. I was wondering if some part of that tooling would be grumpy if blank lines are gone.
package.json
Outdated
| "eslint-plugin-unicorn": "^55.0.0", | ||
| "jsdoc-to-markdown": "^9.1.1" |
There was a problem hiding this comment.
remove unused dependency
| "eslint-plugin-unicorn": "^55.0.0", | |
| "jsdoc-to-markdown": "^9.1.1" | |
| "eslint-plugin-unicorn": "^55.0.0" |
Replaces all other PRs related to driver upgrades.