Mongo 4 no roles check

CHANGELOG.md

@@ -1,5 +1,13 @@
 # bedrock-mongodb ChangeLog
 
+## 11.0.0 -
+
+### Removed
+- **BREAKING**: Remove roles check from authn.
+
+### Added
+- **BREAKING**: Throw if server version is less than 3.6.
+
 ## 10.1.1 -
 
 ### Changed

lib/authn.js

@@ -35,13 +35,6 @@ export async function openDatabase(options) {
   const serverInfo = await admin.serverInfo(null);
   _checkServerVersion({serverInfo, config});
 
-  // check if server supports roles; if not, can't authenticate
-  if(!_usesRoles(serverInfo)) {
-    const stringVersion = serverInfo.versionArray.join('.');
-    throw new BedrockError(
-      `MongoDB server version "${stringVersion}" is unsupported.`,
-      'NotSupportedError');
-  }
   // makes an unauthenticated call to the server
   // to see if auth is required
   const authRequired = await _isAuthnRequired({config, admin});
@@ -89,13 +82,6 @@ async function _connect(options) {
   return {client, db};
 }
 
-function _usesRoles(serverInfo) {
-  // >= Mongo 2.6 uses user roles
-  return (
-    (serverInfo.versionArray[0] == 2 && serverInfo.versionArray[1] >= 6) ||
-    (serverInfo.versionArray[0] > 2));
-}
-
 /**
  * Determines if authn is required.
  *
@@ -128,7 +114,7 @@ async function _isAuthnRequired({config, admin}) {
 
 function _addAuthOptions({options, config}) {
   options.connectOptions.auth = {
-    user: config.username,
+    username: config.username,
     password: config.password
   };
   // authSource is the database to authenticate against
@@ -170,11 +156,22 @@ function _checkServerVersion({serverInfo, config}) {
     url: urls.sanitize(config.url),
     version,
   });
+  // if the server is not at least 3.6.0 throw
+  // as mongo node driver 4 only supports 3.6.0 and higher
+  if(!semver.gte(version, '3.6.0')) {
+    throw new BedrockError(
+      'Unsupported database version.',
+      'NotSupportedError', {
+        url: urls.sanitize(config.url),
+        version,
+        required: '>= 3.6.0'
+      });
+  }
   if(config.requirements.serverVersion &&
     !semver.satisfies(version, config.requirements.serverVersion)) {
     throw new BedrockError(
       'Unsupported database version.',
-      'DatabaseError', {
+      'NotSupportedError', {
         url: urls.sanitize(config.url),
         version,
         required: config.requirements.serverVersion

lib/config.js

@@ -42,6 +42,7 @@ config.mongodb.connectOptions = {
   serverSelectionTimeoutMS: 30000,
   // promotes binary BSON values to native Node.js buffers
   promoteBuffers: true,
+  forceServerObjectId: true,
   // it is recommended to set either ssl or tls to true in production
   // ssl: true
   // tls: true
@@ -56,12 +57,11 @@ config.mongodb.writeOptions = {
     w: 'majority',
     j: true,
   },
-  forceServerObjectId: true,
 };
 
 config.mongodb.requirements = {};
 // server version requirement with server-style string
-config.mongodb.requirements.serverVersion = '>=4.2';
+config.mongodb.requirements.serverVersion = '>=4.4';
 
 // this is used by _createUser to add a user as an admin to a collection
 // config.mongodb.collection = 'admin-collection';

test/test.config.js

@@ -48,6 +48,11 @@ if(process.env.MONGODB_PASSWORD) {
   config.mongodb.password = process.env.MONGODB_PASSWORD;
 }
 
+if(process.env.MONGODB_SERVER_VERSION) {
+  config.mongodb.requirements.serverVersion =
+    process.env.MONGODB_SERVER_VERSION;
+}
+
 //config.mongodb.connectOptions.loggerLevel = 'debug';
 config.mongodb.dropCollections.onInit = true;
 config.mongodb.dropCollections.collections = [];