Patch unauthenticated check #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 87.14% 87.13% -0.02%
==========================================
Files 8 8
Lines 817 816 -1
==========================================
- Hits 712 711 -1
Misses 105 105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Needs rebase. |
aljones15
force-pushed
the
patch-unauthenticated-check
branch
from
d50746f to
98a209c
Compare
dlongley
requested changes
Sep 2, 2022
| */ | ||
| async function _getUnauthenticatedDb({config}) { | ||
| async function _getUnauthenticatedDb({options}) { | ||
| // only use the config stuff with out auth credentials |
Member
There was a problem hiding this comment.
This comment is not correct any more, right? And is this the right thing to do since this is supposed to be an authenticated DB connection?
Member
|
Closing in favor of #107. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further cleans up code in
authn.js, but is untested with major projects.This is not a priority patch and can wait. It is more style and a minor bug fix.