Fix parameter type inference for untyped parameters in extended queries #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2025
sunng87
approved these changes
Sep 10, 2025
- Default to TEXT type instead of throwing fatal errors for unknown parameter types - Allows arithmetic operations with untyped parameters to work through implicit casting - Unify all UTF8 Arrow variants (Utf8, LargeUtf8, Utf8View) to use TEXT type consistently - Resolves schema mismatches between TEXT/VARCHAR type expectations This fixes issues where queries like 'SELECT + ' would fail with 'Unknown parameter type' errors when DataFusion couldn't infer the parameter types from context.
iPeluwa
force-pushed
the
fix/parameter-type-inference
branch
from
4e6cfaf to
24e2db6
Compare
|
@iPeluwa We still have this type of error at https://github.com/datafusion-contrib/datafusion-postgres/blob/master/arrow-pg/src/datatypes/df.rs#L264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues where queries like 'SELECT + ' would fail with 'Unknown parameter type' errors when DataFusion couldn't infer the parameter types from context.