Enhanced Server Stability and Configuration Control #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… query timeout - Fixed parameter type inference for arithmetic operations with untyped parameters (defaults to TEXT instead of throwing fatal errors) - Fixed Arrow schema mismatches by unifying all UTF8 variants to use TEXT type consistently - Added configurable query timeout with ServerOptions.with_query_timeout_secs(0) for no timeout - Added configurable max_connections with ServerOptions.with_max_connections(n) - Added connection limiting with semaphore to prevent resource exhaustion under load - Simplified API with single constructor that takes timeout parameter directly - Added comprehensive unit tests for timeout and connection configuration functionality
- Fixed compiler warnings and clippy suggestions - Updated test files to use new DfSessionService constructor signature - Applied cargo fmt formatting across the codebase - All tests now pass successfully
|
@sunng87 please take a look. |
|
Thank you.
I'm also running into this issue with #149 |
sunng87
reviewed
Sep 9, 2025
| pub fn new( | ||
| session_context: Arc<SessionContext>, | ||
| auth_manager: Arc<AuthManager>, | ||
| query_timeout: Option<std::time::Duration>, |
There was a problem hiding this comment.
I suggest you to put this into a new pull request. Also it should be configured at per-session level using SET statement_timeout
sunng87
reviewed
Sep 9, 2025
| port: 5432, | ||
| tls_cert_path: None, | ||
| tls_key_path: None, | ||
| max_connections: 1000, |
There was a problem hiding this comment.
default to 0, which means no restriction on this.
|
I'd look into that and have it fixed |
|
Hi @iPeluwa , my suggestion is to split this into 3 different PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Parameter Type Issues: Resolved crashes from untyped parameters (e.g., $1 + $2) by setting them to default to TEXT, allowing DataFusion to handle type coercion.
Resolved Schema Consistency Problems: Unified VARCHAR and TEXT types to TEXT, ensuring compatibility with most Postgres tools and eliminating schema mismatches.
Improved Connection Stability: Implemented connection limiting to prevent server crashes from excessive concurrent connections, avoiding resource exhaustion.
Added Configurable Query Timeout: Introduced query timeout settings via ServerOptions::new().with_query_timeout_secs(30) for a 30-second timeout, or 0 for no timeout, to prevent runaway queries.
Enhanced Connection Control: Added .with_max_connections(500) to allow limiting connections, enabling the server to reject excess connections gracefully.