Skip to content

Fix parameter type inference for untyped parameters in extended queries #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

Fix parameter type inference for untyped parameters in extended queries #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions arrow-pg/src/datatypes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ pub fn into_pg_type(arrow_type: &DataType) -> PgWireResult<Type> {
DataType::Float16 | DataType::Float32 => Type::FLOAT4,
DataType::Float64 => Type::FLOAT8,
DataType::Decimal128(_, _) => Type::NUMERIC,
DataType::Utf8 => Type::VARCHAR,
DataType::LargeUtf8 | DataType::Utf8View => Type::TEXT,
DataType::Utf8 | DataType::LargeUtf8 | DataType::Utf8View => Type::TEXT,
DataType::List(field) | DataType::FixedSizeList(field, _) | DataType::LargeList(field) => {
match field.data_type() {
DataType::Boolean => Type::BOOL_ARRAY,
Expand All @@ -67,8 +66,7 @@ pub fn into_pg_type(arrow_type: &DataType) -> PgWireResult<Type> {
| DataType::BinaryView => Type::BYTEA_ARRAY,
DataType::Float16 | DataType::Float32 => Type::FLOAT4_ARRAY,
DataType::Float64 => Type::FLOAT8_ARRAY,
DataType::Utf8 => Type::VARCHAR_ARRAY,
DataType::LargeUtf8 | DataType::Utf8View => Type::TEXT_ARRAY,
DataType::Utf8 | DataType::LargeUtf8 | DataType::Utf8View => Type::TEXT_ARRAY,
struct_type @ DataType::Struct(_) => Type::new(
Type::RECORD_ARRAY.name().into(),
Type::RECORD_ARRAY.oid(),
Expand Down
8 changes: 3 additions & 5 deletions arrow-pg/src/datatypes/df.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,9 @@ where
} else if let Some(infer_type) = inferenced_type {
into_pg_type(infer_type)
} else {
Err(PgWireError::UserError(Box::new(ErrorInfo::new(
"FATAL".to_string(),
"XX000".to_string(),
"Unknown parameter type".to_string(),
))))
// Default to TEXT for untyped parameters in extended queries
// This allows arithmetic operations to work with implicit casting
Ok(Type::TEXT)
}
}

Expand Down
Loading