feat(ack-bump): bump ack-version #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
force-pushed
the
feature/bump-ack-generator
branch
from
7896b67 to
64843e9
Compare
haarchri
force-pushed
the
feature/bump-ack-generator
branch
from
64843e9 to
b913c50
Compare
2 tasks
|
@haarchri is there anything blocking this PR from being merged? |
|
Think only your review - i can Check Last Time a rebase and can Go with it |
…up/CRDVersion to unblock code-gen for IAM Group issue Signed-off-by: haarchri <[email protected]>
haarchri
force-pushed
the
feature/bump-ack-generator
branch
from
b913c50 to
b5cec69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
rename const Group/Version to CRDGroup/CRDVersion to unblock code-gen for ex. IAM issue
Fixes #1025
aws-controllers-k8s/code-generator#251
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested