fix(group): group redeclared issue fixed #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: haarchri [email protected]
Issue aws-controllers-k8s/community#1108 crossplane-contrib/provider-aws#1025
Description of changes:
changed const Group to CRDGroup to fits generated Group for IAM
without this PR:

make generate failed with:
panic: interface conversion: types.Type is nil, not *types.Namedhttps://github.com/haarchri/provider-aws/blob/error/group/apis/iam/v1alpha1/zz_groupversion_info.go#L28
https://github.com/haarchri/provider-aws/blob/error/group/apis/iam/v1alpha1/zz_service_linked_role.go#L144
https://github.com/haarchri/provider-aws/blob/error/group/apis/iam/v1alpha1/zz_types.go#L102
fixed issue with this PR:
code-generator works in crossplane for iam:
https://github.com/haarchri/provider-aws/blob/fix/group/apis/iam/v1alpha1/zz_groupversion_info.go#L28
https://github.com/haarchri/provider-aws/blob/fix/group/apis/iam/v1alpha1/zz_groupversion_info.go#L34
https://github.com/haarchri/provider-aws/blob/fix/group/apis/iam/v1alpha1/zz_service_linked_role.go#L144
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.