Move versioned generator configs to API group folders #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
commented
Jan 26, 2022
| resources: | ||
| "Distribution": | ||
| api_versions: | ||
| - name: "v1alpha1" |
There was a problem hiding this comment.
Configuration example for the Distribution resource. I've tested generating Distribution at v1beta1.
ulucinar
force-pushed
the
unversioned-config
branch
from
cd3da53 to
46c2a73
Compare
|
I get the following when I run Do you get it in your local? |
2 tasks
ulucinar
force-pushed
the
unversioned-config
branch
from
6558cc4 to
7181d87
Compare
- Consume aws-controllers-k8s/code-generator#266 that implements support for specifying API versions of the generated CRDs. - Move generator-config.yaml files to unversioned API group parent folders, because an API Group may now contain multiple versions. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
unversioned-config
branch
from
7181d87 to
199701a
Compare
muvaf
approved these changes
Jan 28, 2022
…config.yaml Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
unversioned-config
branch
from
199701a to
990da01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
Consumes aws-controllers-k8s/code-generator#266 that implements support for specifying API versions of the generated CRDs.
Move
generator-config.yamlfiles to unversioned API group parent folders, because an API Group may now contain multiple versions. Please also note that aws-controllers-k8s/code-generator#266 introduces a backwards-incompatible behavior change: The default location of the generator configuration files, if one is not specified via the command-line with the--option, is nowapis/<API Group>/generator-config.yaml.When aws-controllers-k8s/code-generator#266 is merged, I will update the consumed
code-generatorversion accordingly.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have tried running
provider-awswith a modified configuration for the Cloudfront'sDistributionresource that moves it to the versionv1beta1.[contribution process]: https://git.io/fj2m9